Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Video): Conditionally Render Youtube/Vimeo Videos #3049

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore(Video): Conditionally Render Youtube/Vimeo Videos #3049

wants to merge 6 commits into from

Conversation

smithgajjar09
Copy link
Contributor

@smithgajjar09 smithgajjar09 commented Mar 11, 2025 •
edited
Loading

Overview

Conditionally Render Youtube/Vimeo videos if captions provided or fallback to default embed

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: WEB-3541
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Over here -> https://github.com/codecademy-engineering/mono/pull/9574

PR Links and Envs

Repository PR Link PR Env
Portal Portal Link Portal Env

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 11, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit f97d1f1.

☁️ Nx Cloud last updated this comment at 2025-03-24 08:26:29 UTC

@smithgajjar09 smithgajjar09 changed the title refactor(Video): Conditionally Render Youtube/Vimeo Videos chore(Video): Conditionally Render Youtube/Vimeo Videos Mar 11, 2025
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/gamut@59.3.1-alpha.f97d1f.0
@codecademy/gamut-kit@0.6.488-alpha.f97d1f.0
@codecademy/styleguide@70.5.1-alpha.f97d1f.0

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://67e11747fa57695a3e1a0e4f--gamut-preview.netlify.app

Deploy Logs

@smithgajjar09 smithgajjar09 marked this pull request as ready for review March 24, 2025 17:46
@smithgajjar09 smithgajjar09 requested a review from a team as a code owner March 24, 2025 17:46
LinKCoding
LinKCoding reviewed Mar 25, 2025
View reviewed changes
packages/gamut/src/Video/index.tsx
@@ -90,13 +91,43 @@ export const Video: React.FC<VideoProps> = (props) => {
},
};

const isExternallyHostedVideoUrl = (url: string): boolean =>
!!(url.match(/youtu(be\.com|\.be)/) || url.match(/vimeo.com/));
Copy link
Contributor

@LinKCoding LinKCoding Mar 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency, it should be vimeo\.com

But also wondering if the com or be is necessary? like is there any instance where a different domain is used, like .co.uk
Or is this always ok because the URL is set by a dev and they'll conform to using these domains?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinKCoding LinKCoding LinKCoding left review comments

@aresnik11 aresnik11 Awaiting requested review from aresnik11 aresnik11 is a code owner automatically assigned from Codecademy/gamut

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smithgajjar09 @codecademydev @LinKCoding