Change TuxSuite targets #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we build the config, kernel, and modules target for all configurations and dtbs for the couple of machines that we need them for. The kernel and modules target for tuxsuite is not instructing it to build the kernels and modules; instead, the kernel and modules targets tell tuxsuite to make the kernel image and modules available for download respectively. The default target, which is run as a prerequisite for both of these targets, is what actually builds the kernel image and modules. We do not care about the modules being available after the fact, as we do not use them for anything; we only care that they build. Get rid of the modules target altogether, which may save us from timeouts related to tarring up the modules for download. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
The config target is unnecessary, as it is a dependency of the kernel target. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
There is no point in having a kernel image saved that we cannot boot. Use the default target for these builds to make tuxsuite do a little less work. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nickdesaulniers
approved these changes
Dec 9, 2021
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series updates the targets that we call for TuxSuite, which will save us a little bit of work (maybe more for modules). See the individual commits for each change to understand the rationale.