use C++ style casts

Author: ChrisHal

QtPMbrowser/pmbrowserwindow.cpp

@@ -437,7 +437,7 @@ void PMbrowserWindow::exportSubTree(QTreeWidgetItem* item, const QString& path,
                 PackedFileRecordHeader pfrh{ kDataFolderStartRecord,0,32 };
                 char buf[32]{};
                 item->text(0).toStdString().copy(buf, 31);
-                poutfile->write((char*)&pfrh, sizeof(PackedFileRecordHeader));
+                poutfile->write(reinterpret_cast<char*>(&pfrh), sizeof(PackedFileRecordHeader));
                 poutfile->write(buf, 32);
             }
         }
@@ -446,7 +446,7 @@ void PMbrowserWindow::exportSubTree(QTreeWidgetItem* item, const QString& path,
         }
         if (export_type == ExportType::Igor && new_datafolder) {
             PackedFileRecordHeader pfrh{ kDataFolderEndRecord,0,0 };
-            poutfile->write((char*)&pfrh, sizeof(PackedFileRecordHeader));
+            poutfile->write(reinterpret_cast<char*>(&pfrh), sizeof(PackedFileRecordHeader));
         }
     }
     else {
@@ -482,12 +482,12 @@ void PMbrowserWindow::exportSubTree(QTreeWidgetItem* item, const QString& path,
                 PackedFileRecordHeader pfrh{};
                 pfrh.recordType = kWaveRecord;
                 size_t offset_record = poutfile->tellp();
-                poutfile->write((char*)&pfrh, sizeof(PackedFileRecordHeader));
+                poutfile->write(reinterpret_cast<char*>(&pfrh), sizeof(PackedFileRecordHeader));
                 ExportTrace(infile, *traceentry, *poutfile, wavename.toStdString());
                 size_t offset_end = poutfile->tellp();
                 pfrh.numDataBytes = int32_t(offset_end - offset_record - sizeof(PackedFileRecordHeader));
                 poutfile->seekp(offset_record);
-                poutfile->write((char*)&pfrh, sizeof(PackedFileRecordHeader));
+                poutfile->write(reinterpret_cast<char*>(&pfrh), sizeof(PackedFileRecordHeader));
                 poutfile->seekp(offset_end);
             }
         }

hekatoolslib/DatFile.h

@@ -134,13 +134,13 @@ namespace hkLib {
 
 		auto source = std::make_unique<T[]>(trdatapoints);
 		if (interleavesize == 0) {
-			datafile.read((char*)source.get(), sizeof(T) * trdatapoints);
+			datafile.read(reinterpret_cast<char*>(source.get()), sizeof(T) * trdatapoints);
 		}
 		else { // it's interleaved data
 			assert(interleaveskip >= interleavesize);
 			std::size_t bytesremaining = sizeof(T) * trdatapoints;
 			int bytestoskip = interleaveskip - interleavesize; // interleaveskip is from block-start to block-start!
-			char* p = (char*)source.get();
+			char* p = reinterpret_cast<char*>(source.get());
 			while (bytesremaining > 0) {
 				auto bytestoread = std::min(bytesremaining, std::size_t(interleavesize));
 				datafile.read(p, bytestoread);

hekatoolslib/exportIBW.cpp

@@ -136,9 +136,9 @@ namespace hkLib {
 		cksum = Checksum(reinterpret_cast<char*>(&wh), cksum, numbytes_wh);
 		bh.checksum = -cksum;
 
-		outfile.write((char*)&bh, sizeof(bh));
-		outfile.write((char*)&wh, numbytes_wh);
-		outfile.write((char*)target.get(), sizeof(double) * trdatapoints);
+		outfile.write(reinterpret_cast<char*>(&bh), sizeof(bh));
+		outfile.write(reinterpret_cast<char*>(&wh), numbytes_wh);
+		outfile.write(reinterpret_cast<char*>(target.get()), sizeof(double) * trdatapoints);
 		outfile.write(note.data(), note.size());
 	}
 
@@ -149,8 +149,8 @@ namespace hkLib {
 		PlatformInfo pli{ 2, 2, {0}, {0} };
 		//double igorVersion = 5.00;
 		//std::memcpy(pli.igorVersion, &igorVersion, sizeof(double));
-		outfile.write((char*)&pfrh, sizeof(PackedFileRecordHeader));
-		outfile.write((char*)&pli, sizeof(PlatformInfo));
+		outfile.write(reinterpret_cast<char*>(&pfrh), sizeof(PackedFileRecordHeader));
+		outfile.write(reinterpret_cast<char*>(&pli), sizeof(PlatformInfo));
 	}
 
 	void WriteIgorProcedureRecord(std::ostream& outfile)
@@ -159,13 +159,13 @@ namespace hkLib {
 		constexpr auto history_txt = "// pxp file created by PMbrowser\r"
 			"// Use \"Macros\" --> \"Display Waves\" to create graphs\r"sv;
 		PackedFileRecordHeader pfhr{ kHistoryRecord,0, int32_t(history_txt.size()) };
-		outfile.write((char*)&pfhr, sizeof(PackedFileRecordHeader));
+		outfile.write(reinterpret_cast<char*>(&pfhr), sizeof(PackedFileRecordHeader));
 		outfile.write(history_txt.data(), history_txt.size());
 		pfhr = { kProcedureRecord,0, int32_t(Igor_ipf.size()) };
-		outfile.write((char*)&pfhr, sizeof(PackedFileRecordHeader));
+		outfile.write(reinterpret_cast<char*>(&pfhr), sizeof(PackedFileRecordHeader));
 		outfile.write(Igor_ipf.data(), Igor_ipf.size());
 		pfhr = { kGetHistoryRecord,0,0 };
-		outfile.write((char*)&pfhr, sizeof(PackedFileRecordHeader));
+		outfile.write(reinterpret_cast<char*>(&pfhr), sizeof(PackedFileRecordHeader));
 	}
 
 	void ExportAllTraces(std::istream& datafile, DatFile& datf, const std::string& path, const std::string& prefix)