small fixes

Author: Chr157i4n

.github/workflows/test.yml

@@ -46,7 +46,7 @@ jobs:
         pip install pyserial
     - name: Analysing the code with pylint
       run: |
-        pylint $(git ls-files '*.py') --disable=C0103 --disable=W0511 --disable=W0012 --extension-pkg-whitelist=RPi --max-line-length=160
+        pylint $(find -wholename './src/*.py') --disable=C0103 --disable=W0511 --disable=W0012 --extension-pkg-whitelist=RPi --max-line-length=160
 
 
   unittest:

demo/debug_script_01_uart_connection.py

@@ -33,7 +33,7 @@
     tmc = Tmc2209(None, None)
 else:
     # just in case
-    tmc = Tmc2209(None)
+    tmc = Tmc2209(None, None)
 
 
 if BOARD == Board.RASPBERRY_PI:

src/__init__ .py src/tmc_driver/com/__init__.py

@@ -29,8 +29,8 @@ def __init__(self,
             _tmc_logger (class): TMCLogger class
             mtr_id (int, optional): driver address [0-3]. Defaults to 0.
         """
-        self._tmc_logger = tmc_logger
-        self.mtr_id = mtr_id
+        super().__init__(mtr_id, tmc_logger)
+        raise NotImplementedError
 
 
 

src/tmc_driver/com/_tmc_com_spi.py

@@ -44,7 +44,8 @@ def __init__(self,
             baudrate (int): baudrate
             mtr_id (int, optional): driver address [0-3]. Defaults to 0.
         """
-        self._tmc_logger = tmc_logger
+        super().__init__(mtr_id, tmc_logger)
+
         if serialport is None:
             return
         try:
@@ -60,7 +61,6 @@ def __init__(self,
                                     You may need to add your user to the dialout group
                                     with \"sudo usermod -a -G dialout pi\"""")
 
-        self.mtr_id = mtr_id
         # adjust per baud and hardware. Sequential reads without some delay fail.
         self.communication_pause = 500 / baudrate
 

src/tmc_driver/com/_tmc_com_uart.py

@@ -1,4 +1,8 @@
 #pylint: disable=too-many-instance-attributes
+#pylint: disable=too-many-arguments
+#pylint: disable=too-many-public-methods
+#pylint: disable=too-many-branches
+#pylint: disable=too-many-positional-arguments
 """
 VActual Motion Control module
 """

src/tmc_driver/com/__init__ .py src/tmc_driver/enable_control/__init__.py

@@ -81,7 +81,7 @@ def stallguard_callback(self, gpio_pin):
 
 
 
-    def do_homing(self, diag_pin, revolutions = 10, threshold = None, speed_rpm = None):
+    def do_homing(self, diag_pin, revolutions = 10, threshold = None, speed_rpm = None) -> bool:
         """homes the motor in the given direction using stallguard.
         this method is using vactual to move the motor and an interrupt on the DIAG pin
 
@@ -97,7 +97,7 @@ def do_homing(self, diag_pin, revolutions = 10, threshold = None, speed_rpm = No
         """
         if self.tmc_com is None:
             self.tmc_logger.log("do_homing only works with VActual register control via COM", Loglevel.ERROR)
-            return
+            return False
 
         if threshold is not None:
             self._sg_threshold = threshold