Visual Studio Package unregisters TSK Package

[Chizaruu]

Current Behavior

The recent version of the Visual Studio Package unregisters the TSK package from being a choice in External Tools.

Reproduction / Steps To Reproduce

1. Install Visual Studio Package
2. Find that the TSK package option is unregistered from External tools

Anything else?

That is an excellent way of saying hello, Microsoft.

Note: the Visual Studio Code Editor package is a legacy package that is not maintained anymore. The Visual Studio Editor package now handles the entire family of Visual Studio products.

[Chizaruu]

Found the issue in VisualStudioEditor.cs in the Visual Studio Package

#if UNITY_2019_4_OR_NEWER && !UNITY_2020
		[InitializeOnLoadMethod]
		static void LegacyVisualStudioCodePackageDisabler()
		{
			// disable legacy Visual Studio Code packages
			var editor = CodeEditor.Editor.GetCodeEditorForPath("code.cmd");
			if (editor == null)
				return;

			if (editor is VisualStudioEditor)
				return;

			CodeEditor.Unregister(editor);
		}
#endif

I will patch it later tonight or this weekend.

[Chizaruu]

K, pretty easy solution, uninstall the Visual Studio package.

Saltiness aside, I welcome someone else to patch this issue or convince the Microsoft/Unity team to remove these lines of code.

For now, I'll update the README.md for new users coming across this package. ✌️

[Chizaruu]

microsoft/vscode-dotnettools#323 (comment)

Hi @Chizaruu, we updated our package to only disable the legacy com.unity.ide.vscore package.

Regarding "Both packages can be used at the same time", yes you are right for the discovery and when you explicitly select an installation during the session.

Just waiting on the next package update release before I can close this issue.