Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync hashBlocks performance issue #2857

Closed
dapplion opened this issue Jul 20, 2021 · 2 comments
Closed

sync hashBlocks performance issue #2857

dapplion opened this issue Jul 20, 2021 · 2 comments
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.

Comments

@dapplion
Copy link
Contributor

Describe the bug

Sync module tracks the blocks downloaded to do peer scoring latter. However a CPU profile reveals it's a very expensive operation. How can the sync module track the blocks in a succinct unique manner without having to hash all the blocks upfront?

Screenshot from 2021-07-20 14-27-42

Expected behavior

Track blocks in a cheap manner

Steps to Reproduce

Screenshots

Desktop (please complete the following information):

  • OS:
  • Version:
  • Branch:
  • Commit hash:
@dapplion dapplion added prio-low This is nice to have. testnet-debugging scope-performance Performance issue and ideas to improve performance. labels Jul 20, 2021
@stale
Copy link

stale bot commented Sep 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta-stale label Sep 19, 2021
@dapplion dapplion added prio-medium Resolve this some time soon (tm). and removed prio-low This is nice to have. labels Sep 20, 2021
@stale stale bot removed meta-stale labels Sep 20, 2021
@dapplion
Copy link
Contributor Author

ssz v2 should cache the blocks root so not extra processing is done in the blocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.
Projects
None yet
Development

No branches or pull requests

1 participant