Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: update peerstore and releated deps for libp2p@0.45 compat #425

Conversation

achingbrain
Copy link
Collaborator

@achingbrain achingbrain commented May 10, 2023

Updates all libp2p deps to fix up use of gossipsub with libp2p@0.45.x

Refs: libp2p/js-libp2p-peer-store#75

BREAKING CHANGE: requires libp2p@0.45.x

Updates all libp2p deps to fix up use of gossipsub with `libp2p@0.45.x`
@achingbrain achingbrain requested a review from a team as a code owner May 10, 2023 06:16
@what-the-diff
Copy link

what-the-diff bot commented May 10, 2023

PR Summary

  • Updated peer store with a new interface
    An improvement to the peer store to use a more efficient and modern interface
  • Added events property for testing
    Enhancement for developers to test components with events property added to the object
  • Removed unused RecordEnvelope import and related code
    Cleanup done by removing unnecessary code and imports related to peer record handling, since it's now managed in the peer store
  • Modified connection manager event listener
    For better functionality, the connection manager event listener has been changed from 'peer:connect' to 'libp2p:connection-manager/new-connection'

@achingbrain achingbrain changed the title deps: update peerstore and releated deps for libp2p@0.45 compat fix: update peerstore and releated deps for libp2p@0.45 compat May 10, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 48.57% and project coverage change: -0.02 ⚠️

Comparison is base (f62859b) 82.96% compared to head (cadfaf4) 82.95%.

❗ Current head cadfaf4 differs from pull request most recent head bf74ab2. Consider uploading reports for the commit bf74ab2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
- Coverage   82.96%   82.95%   -0.02%     
==========================================
  Files          48       48              
  Lines       11878    11896      +18     
  Branches     1281     1281              
==========================================
+ Hits         9855     9868      +13     
- Misses       2023     2028       +5     
Impacted Files Coverage Δ
src/index.ts 70.12% <5.88%> (-0.09%) ⬇️
test/compliance.spec.ts 41.46% <50.00%> (+1.98%) ⬆️
test/utils/create-pubsub.ts 81.53% <100.00%> (+1.53%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@achingbrain achingbrain changed the title fix: update peerstore and releated deps for libp2p@0.45 compat fix!: update peerstore and releated deps for libp2p@0.45 compat May 12, 2023
@achingbrain
Copy link
Collaborator Author

@wemeetagain any chance of a review here?

Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants