fix: tracer to track delivered message if duplicate

[twoeths]

Motivation

• To investigate broken promises in v1.2.1: Low mesh peers due to p7 lodestar#4818
• Consider this scenario
  • 2 messages have same fastMsgId but different msgIds (collision)
  • node sends IWANT control message and add a promise
  • message 1 comes and being tracked in fastMsgId
  • message 2 (as a response to IWANT) comes, since it has same fastMsgId it's a duplicate we didn't mask as "message delivered" in tracer, and it looks like the other node did not send us the requested messages

Description

• call tracer. deliverMessage() in the case of message duplicate

part of ChainSafe/lodestar#4818

[codecov-commenter]

Codecov Report

Base: 83.26% // Head: 83.22% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (55cdaad) compared to base (dbeb879).
Patch coverage: 45.45% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
- Coverage   83.26%   83.22%   -0.04%     
==========================================
  Files          48       48              
  Lines       11787    11797      +10     
  Branches     1266     1266              
==========================================
+ Hits         9814     9818       +4     
- Misses       1973     1979       +6     

Impacted Files	Coverage Δ
src/metrics.ts	21.75% <0.00%> (-0.16%)	⬇️
src/tracer.ts	77.01% <50.00%> (-0.45%)	⬇️
src/index.ts	69.82% <100.00%> (+0.04%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[dapplion]

Can you add metrics to verify this hypothesis?

• Add a second parameter to deliverMessage(msg, isDuplicate: boolean)
• In that function, if promise resolved and isDuplicate then this.metrics.iwantPromiseResolvedFromDuplicate.inc(1)

[twoeths]

thanks @dapplion for the metric, it shows a lot of promises could be resolved by duplicate messages (this is from a mainnet node subscribing to all subnets)

it could reduce 80% 90% of broken promises (this was only tested 3h but we could trust as these 2 metrics match each other)