fix: support parsing IPv6 addresses with zone indexes in browsers #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPv6 addresses like `fe80::8cb1:25ff:fec5:28e3%llw0` are valid but contain a zone index. This is parsed correctly by the `net` module on node but not by the browser polyfill here. The fix here is just to strip the `%` character and anyything that follows it from the input string. Adds a test for this, and also adds support for running the tests in Chrome in dev and CI. Fixes ChainSafe#9
mpetrunic
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPv6 addresses like
fe80::8cb1:25ff:fec5:28e3%llw0are valid but contain a zone index. This is parsed correctly by thenetmodule on node but not by the browser polyfill here.The fix here is just to strip the
%character and anything that follows it from the input string.Adds a test for this, and also adds support for running the tests in Chrome in dev and CI.
Fixes #9