Merge branch 'master' into polylinesOnTerrainCheckDuplicates

Author: likangning93

CONTRIBUTORS.md

@@ -44,6 +44,7 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu
    * [William Ho](https://github.com/williamkho)
    * [Srinivas Kaza](https://github.com/AnimatedRNG)
    * [Hannah Bollar](https://github.com/hanbollar)
+   * [Jane Xu](https://github.com/janeyx99)
    * [Luke San Antonio Bialecki](https://github.com/lukesanantonio)
    * [Josh Lawrence](https://github.com/loshjawrence)
    * [Omar Shehata](https://github.com/OmarShehata)

Documentation/Contributors/CodingGuide/README.md

@@ -507,10 +507,10 @@ Because result parameters aren't always required or returned, don't strictly rel
 ```js
 Cartesian3.add(v0, v1, result);
 Cartesian3.add(result, v2, result);
-``` 
+```
 is better written as
 ```js
-result = Cartesian3.add(v0, v1, result); 
+result = Cartesian3.add(v0, v1, result);
 result = Cartesian3.add(result, v2, result);
 ```
 
@@ -544,6 +544,21 @@ var p = new Cartesian3(1.0, 2.0, 3.0);
 p.x = 'Cesium'; // Changes x to a string, slows down property access
 ```
 
+* In a constructor function, consider properties as write once; do not write to them or read them multiple times. Create a local variable if they need to be ready. For example:
+
+  Instead of
+  ```javascript
+  this._x = 2;
+  this._xSquared = this._x * this._x;
+  ```
+
+  prefer
+  ```javascript
+  var x = 2;
+  this._x = x;
+  this._xSquared = x * x;
+  ```
+
 ### `from` Constructors
 
 :art: Constructor functions should take the basic components of the class as parameters.  For example, `Cartesian3` takes `x`, `y`, and `z`.

gulpfile.js

@@ -24,7 +24,7 @@ var gulpRename = require('gulp-rename');
 var gulpReplace = require('gulp-replace');
 var Promise = require('bluebird');
 var requirejs = require('requirejs');
-var karma = require('karma').Server;
+var Karma = require('karma').Server;
 var yargs = require('yargs');
 var aws = require('aws-sdk');
 var mime = require('mime');
@@ -634,16 +634,16 @@ gulp.task('test', function(done) {
         files.push({pattern : 'Build/**', included : false});
     }
 
-    karma.start({
+    var karma = new Karma({
         configFile: karmaConfigFile,
-        browsers : browsers,
+        browsers: browsers,
         specReporter: {
             suppressErrorSummary: false,
             suppressFailed: false,
             suppressPassed: suppressPassed,
             suppressSkipped: true
         },
-        detectBrowsers : {
+        detectBrowsers: {
             enabled: enableAllBrowsers
         },
         files: files,
@@ -653,6 +653,7 @@ gulp.task('test', function(done) {
     }, function(e) {
         return done(failTaskOnError ? e : undefined);
     });
+    karma.start();
 });
 
 gulp.task('generateStubs', ['build'], function(done) {

package.json

@@ -54,7 +54,7 @@
     "gulp-zip": "^4.0.0",
     "jasmine-core": "^3.1.0",
     "jsdoc": "^3.4.3",
-    "karma": "^2.0.0",
+    "karma": "^2.0.3",
     "karma-chrome-launcher": "^2.0.0",
     "karma-detect-browsers": "^2.2.3",
     "karma-edge-launcher": "^0.4.2",