Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catala-language-server: test case format should include prose sections and possibly metadata #673

Open
rprimet opened this issue Sep 3, 2024 · 1 comment
Assignees
Labels
💬 discussion Further discussion is needed ✨ enhancement New feature or request 🤩 ide IDE plugins and tooling

Comments

@rprimet
Copy link
Contributor

rprimet commented Sep 3, 2024

The current format for test cases (those that are rendered by the UI aimed at non-programmers) is a list of Test instances, each of which is a function invocation (with inputs and a list of assertions on the return value).

We should also include comments and possibly metadata on the test fields, as those are highly valued by test writers and readers (see the catala seminar on payfit for an example).

This issue is there to discuss what we want to support in terms of prose and/or metadata

@rprimet rprimet self-assigned this Sep 3, 2024
@denismerigoux denismerigoux added ✨ enhancement New feature or request 💬 discussion Further discussion is needed 🤩 ide IDE plugins and tooling labels Sep 3, 2024
@denismerigoux
Copy link
Contributor

I agree on the need for metadata and comments in tests. We already have some examples of what a fully commented and qualified test looks like on the income tax study : see e.g. page 187 impot_revenu.pdf. Because Catala uses literate programming, I feel that the right place for explaining what a test case should do is within the Catala file itself, as Mardown text before the snippet of Catala code containing the code of the test case scope.

Concerning more localized comments on the test fields, they can be stored as comments in the Catala code snippets. This might be a good occasion to kickstart the normalization effort of Catala code comments with a proper attribute language that @rprimet's IDE could pick up (see #392).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 discussion Further discussion is needed ✨ enhancement New feature or request 🤩 ide IDE plugins and tooling
Projects
Status: Inactive
Development

No branches or pull requests

2 participants