Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default styling properties that block vector rendering #549

Closed
makella opened this issue Jun 12, 2017 · 3 comments
Closed

Remove default styling properties that block vector rendering #549

makella opened this issue Jun 12, 2017 · 3 comments
Labels

Comments

@makella
Copy link
Contributor

makella commented Jun 12, 2017

As discussed in this issue (CartoDB/carto.js#1670) and this issue (CartoDB/carto.js#1624) we have some default properties blocking vector rendering. Specifically, polygon-gamma and line-comp-op.

I think Auto-Style is actually the best use of these properties but I understand why we need to remove them.

Basically, we need to remove polygon-gamma and line-comp-op properties from here:
https://github.com/CartoDB/deep-insights.js/blob/master/src/widgets/auto-style/auto-styler.js#L41-L50

cc @donflopez @saleiva

@makella makella added the vector label Jun 12, 2017
@makella
Copy link
Contributor Author

makella commented Jun 12, 2017

One thing we need to test is how we should modify the default Auto-Style CartoCSS with these properties removed.

I will test in Builder by modifying the Auto-Style CartoCSS to see what a suitable alternative is.

@makella
Copy link
Contributor Author

makella commented Jun 12, 2017

So if we remove those properties, there is no effect the real problem with Auto-Style on polygons is still this unresolved issue with lines trying to ramp and not working:
#518

We should definitely test when modifications are made. For polygons, all we need is to not overwrite line-color when auto-style is enabled.

@xavijam
Copy link
Contributor

xavijam commented Jul 4, 2017

Hey @makella, taking care of this one in #557. Closing this one!

Thanks! 💋 .

@xavijam xavijam closed this as completed Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants