[SMOKES] Dynamic VS Vector decision + Vector Infowindows / Tooltips

[pabletecodes]

This PR implements 3 things:

1. VisView (and MapView) is now rendered after the map is first reloaded.
2. CARTO.js now decides whether to use vector or raster. DEPENDS ON Include stats in the response to map instantiation requests Windshaft-cartodb#664.
3. Infowindows & Tooltips for vector rendering.

We'll be running some SMOKE tests for these changes.

Fixes: CartoDB/cartodb#11783

[donflopez]

🇪🇸

[donflopez]

I did the acceptance steps and it works perfectly.

One thing, vector will not work because it needs some changes that are under dynamic-raster-vs-vector-decision-2 and a new release of tangram.cartodb

[pabletecodes]

True fact @donflopez! Should we cherry-pick those changes so that we can release this?

[donflopez]

Yes, sure!

[donflopez]

I already did this! We should try it in staging.

[donflopez]

It is working on ded02, if you want to try @alonsogarciapablo, I think we're ready to merge :)

[donflopez]

Well, I just tried with a torque map and it fails with the next error:

vis-view.js:104 Uncaught TypeError: Cannot read property 'invalidateSize' of undefined

[donflopez]

Torque is now working, it needs this changes on deep-insights.js

[donflopez]

I've noticed that the time series widget is not being animated like the map content.

[pabletecodes]

retest this please

[donflopez]

Important reminder!

Some properties set by default are not supported by Tangram and the decision always goes for raster.

We have to think which solution is the best for this cases:

1.- Support those properties.

This can be a pain where most hurt. It is gonna take time and collaboration with Mapzen.

2.- Remove those properties from default ccss.

This has some inconveniences that @makella can explain better than me, some of them are that raster needs some of them to make the visualisations smoother and we have raster in Builder.

3.- Ignore those properties in Tangram.

IMO, this is the best option because we don't affect to the Builder visualisation and we can get rid of those properties that doesn't affect pretty much in visualisations terms in vector.

cc/ @javisantana, @jorgesancha, @rochoa, @makella

[makella]

The one property that we have by default that isn't supported by Tangram is the polygon-gamma as @donflopez mentioned, this smooths out polygonal data and makes a big difference with things like choropleth maps.

On the other hand, the only place that we have this default is when polygons are first added. As soon as the user modifies any styling property, polygon-gamma and any other custom styling properties are lost so in reality, it isn't a big deal.

Paco and I did some testing and it seemed that the Tangram rendering did an ok job with the rendering so I'd agree with him that if we can ignore these properties and still get the map to vector rendering that would be preferable instead of something like polygon-gamma being something that stops people from getting vector maps.

[donflopez]

I'd like to add some other properties that aren't fully supported like line-comp-op: soft-light we only support multiply, add and overlay at this moment.

Thank you @makella! 🙂

[makella]

@donflopez oh yes, that's another default cartocss property for polygons :)

[pabletecodes]

@makella thanks for your input! ❤️

So the idea is to ignore all of the default properties that are not supported by tangram? Should we make a list of these properties or they are just the ones you guys already mentioned (polygon-gamma and line-comp-op: soft-light)? Not sure if other types of geometries have some unsupported props. Here's the default CartoCSS:

#layer['mapnik::geometry_type'=1] {
  marker-width: 7;
  marker-fill: #FFB927;
  marker-fill-opacity: 0.9;
  marker-line-color: #FFF;
  marker-line-width: 1;
  marker-line-opacity: 1;
  marker-placement: point;
  marker-type: ellipse;
  marker-allow-overlap: true;
}
#layer['mapnik::geometry_type'=2] {
  line-color: #3EBCAE;
  line-width: 1.5;
  line-opacity: 1;
}
#layer['mapnik::geometry_type'=3] {
  polygon-fill: #374C70;
  polygon-opacity: 0.9;
  polygon-gamma: 0.5;
  line-color: #FFF;
  line-width: 1;
  line-opacity: 0.5;
  line-comp-op: soft-light;
}

Also, not sure if auto-styling might set some props that won't work with Tangram.

@makella you're the boss here! Thanks!

cc: @jorgesancha

[javisantana]

If outostyle set a not suported property we should remove it if it's not that important or add support for it.

For example, in case of line-comp-op: soft-light we should remove it from autostyle or default style.

I understand the visual quality is not the same but we should take into account we can't do everything and we need to cut scope at some point

[pabletecodes]

We are going to release this internally as is and we can then continue with this discussion and tune things a bit more.

[pabletecodes]

Retest this please!