Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vector] Remove default styling properties for polygons that aren't supported for vector #1670

Closed
makella opened this issue Jun 12, 2017 · 2 comments

Comments

@makella
Copy link

makella commented Jun 12, 2017

After talking with @donflopez and understanding the constraints of all default properties for polygon features blocking vector rendering, we decided, let's go ahead and remove them.

These properties are specifically for smoother rendering between polygons and lines and are more important for things like choropleth maps.

But with vector rendering, we are noticing better lines on the published map than with raster:

screen shot 2017-06-12 at 8 47 02 am

In addition, anytime you change styling in the forms the polygon-gamma and line-comp-op properties are reset and no longer persist through to the users styling.

We can go ahead and remove the properties that are blocking and default to the CartoCSS below for polygon fills:

#layer {
  polygon-fill: #374C70;
  polygon-opacity: 0.9;
  line-color: #FFF;
  line-width: 1;
  line-opacity: 0.5;
}

Which with vector will look like this:
screen shot 2017-06-12 at 8 45 08 am

cc @saleiva

@makella
Copy link
Author

makella commented Jun 12, 2017

And as mentioned in this issue (#1624) we should remove it from Auto-Style as well.

I can do the PR if you need, just let me know!

thanks

@rochoa rochoa changed the title Remove default styling properties for polygons that aren't supported for vector [Vector] Remove default styling properties for polygons that aren't supported for vector Jun 21, 2017
@rochoa
Copy link
Contributor

rochoa commented Jul 25, 2017

This is already done.

@rochoa rochoa closed this as completed Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants