Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tests for more accurate PROJ #998

Merged
merged 7 commits into from
Jul 11, 2018
Merged

Adapt tests for more accurate PROJ #998

merged 7 commits into from
Jul 11, 2018

Conversation

jgoizueta
Copy link
Contributor

This fixes #994

Tests are adapted so that points that lie on the border of tiles can appear in multiple aggregated tiles.

I tried to add some nested describe blocks to separate tests without duplicated points, but I got into trouble because of this

I'm considering avoiding the duplicated points between tiles as proposed in #889, but for the time being here are the tests adjusted.

Fixes #994
With exact point 0,0 transformations, the point is between tiles and can appear in several
Some sample tests, which cannot use RNG seeding, are nondeterministical.
Increment size of test table used in sampling tests to make less likely that the sample is empty
They were not numerical accuracy independent, as intended
@jgoizueta jgoizueta merged commit b5a0c65 into master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test: Invalid aggregation test with PROJ 5.1
2 participants