Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reserved spaces for local competitors in finals #57

Merged

Conversation

ohexter
Copy link
Collaborator

@ohexter ohexter commented Aug 19, 2024

No description provided.

@Jobarion
Copy link

This doesn't seem to take into account rounds before the final round. If the final has reserved spaces, all previous rounds should also have reserved spaces with the same conditions as the final.

@ohexter
Copy link
Collaborator Author

ohexter commented Aug 22, 2024

This is certainly possible, but the problem statement has typically been expressed in terms of finals and I'm not aware of a need for further allowances.

@Jobarion
Copy link

Since qualifying for all previous rounds is a prerequisite for participating in a final I don't see a good reason not to reserve spaces in previous rounds as well. The goal of this change is to make sure at least N competitors from a given region will be in the final. This is not guranteed if nobody from that region qualifies for the semi final.

@CarterKoala
Copy link
Owner

I think it makes sense - it's just a minor wording change. It shouldn't matter for semifinals except in very extreme cases, but I think it still makes sense to allow for this.

Copy link
Collaborator Author

@ohexter ohexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow for all progression rather than just final rounds

Avoid issues at comps with multiple championship types
Align spaces vs. places for consistency
CarterKoala and others added 2 commits August 27, 2024 00:38
Co-authored-by: ohexter <116421789+ohexter@users.noreply.github.com>
Co-authored-by: ohexter <116421789+ohexter@users.noreply.github.com>
@CarterKoala CarterKoala merged commit a95f6bc into championship-advancements Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants