Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate extension in two #6

Open
Peque opened this issue Feb 26, 2019 · 2 comments
Open

Separate extension in two #6

Peque opened this issue Feb 26, 2019 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@Peque
Copy link
Collaborator

Peque commented Feb 26, 2019

  • One for general 3D files visualization (i.e.: STL, three.js, AMF...).
  • One for CadQuery visualizations

Notes:

  • Installing and enabling CadQuery's extension should install and enable the visualization extension
  • CadQuery's could simply replace .. cadquery:: with .. code:: + .. show3d:: (how do we make sure we propagate the parameters like height, width, etc.?)
@Peque Peque added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Feb 26, 2019
@Peque
Copy link
Collaborator Author

Peque commented Mar 4, 2019

Or maybe simply rename this project and implement multiple directives: cadquery, stl, xxx...

@shimwell
Copy link
Contributor

multiple directives sounds great to me. Might also consider another directive for CadQuery as they have assembly support now (with different color parts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Peque @shimwell