fix: Export RemoveDeadFuncsError
#1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborgna-q
force-pushed
the
ab/export-dead-fn-pass-error
branch
from
9263116 to
09bd748
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1883 +/- ##
=======================================
Coverage 86.55% 86.55%
=======================================
Files 195 195
Lines 35584 35584
Branches 32397 32397
=======================================
Hits 30800 30800
Misses 3012 3012
Partials 1772 1772
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Closed
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
## 🤖 New release * `hugr`: 0.14.3 * `hugr-core`: 0.14.3 * `hugr-model`: 0.17.1 * `hugr-llvm`: 0.14.3 * `hugr-passes`: 0.14.3 * `hugr-cli`: 0.14.3 <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## [0.14.3](hugr-v0.14.2...hugr-v0.14.3) - 2025-02-05 ### Bug Fixes - Export `RemoveDeadFuncsError` (#1883) - const-folding Module keeps at least "main" (#1901) - determine correct bounds of custom types (#1888) - Exporting converging control flow edges (#1890) ### Documentation - Fix deprecation warning messages (#1891) - Explain why `ConstF64` is not PartialEq (#1829) ### New Features - Special cased array, float and int constants in hugr-model export (#1857) - Simplify hugr-model (#1893) </blockquote> ## `hugr-core` <blockquote> ## [0.14.3](hugr-core-v0.14.2...hugr-core-v0.14.3) - 2025-02-05 ### Bug Fixes - determine correct bounds of custom types (#1888) - Exporting converging control flow edges (#1890) ### Documentation - Explain why `ConstF64` is not PartialEq (#1829) ### New Features - Special cased array, float and int constants in hugr-model export (#1857) - Simplify hugr-model (#1893) </blockquote> ## `hugr-model` <blockquote> ## [0.17.1](hugr-model-v0.17.0...hugr-model-v0.17.1) - 2025-02-05 ### Bug Fixes - determine correct bounds of custom types (#1888) ### New Features - Special cased array, float and int constants in hugr-model export (#1857) - Simplify hugr-model (#1893) - Do not require `capnp` to be installed to compile `hugr-model` (#1907) </blockquote> ## `hugr-llvm` <blockquote> ## [0.14.2](hugr-llvm-v0.14.1...hugr-llvm-v0.14.2) - 2025-01-20 ### New Features - *(hugr-llvm)* Emit more int ops (#1835) - Constant values in `hugr-model` (#1838) - *(hugr-llvm)* Emit ipow (#1839) ### Refactor - *(hugr-llvm)* [**breaking**] Optimise the llvm types used to represent hugr sums. (#1855) ### Testing - Fix failing inot test (#1841) </blockquote> ## `hugr-passes` <blockquote> ## [0.14.3](hugr-passes-v0.14.2...hugr-passes-v0.14.3) - 2025-02-05 ### Bug Fixes - Export `RemoveDeadFuncsError` (#1883) - const-folding Module keeps at least "main" (#1901) ### Documentation - Fix deprecation warning messages (#1891) </blockquote> ## `hugr-cli` <blockquote> ## [0.14.1](hugr-cli-v0.14.0...hugr-cli-v0.14.1) - 2024-12-18 ### New Features - Print `hugr-cli`'s correct version when using '--version' (#1790) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: Agustín Borgna <agustin.borgna@quantinuum.com>
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
## 🤖 New release * `hugr`: 0.14.3 -> 0.14.4 (✓ API compatible changes) * `hugr-core`: 0.14.3 -> 0.14.4 (✓ API compatible changes) * `hugr-llvm`: 0.14.3 -> 0.14.4 (✓ API compatible changes) * `hugr-passes`: 0.14.3 -> 0.14.4 * `hugr-cli`: 0.14.3 -> 0.14.4 <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## [0.14.4](hugr-v0.14.3...hugr-v0.14.4) - 2025-02-24 ### Bug Fixes - delegate default impls in HugrView (#1921) ### New Features - add xor to logic extension (#1911) - Add `Type::as_sum` and `SumType::variants`. (#1914) - Add `HugrMutInternals::insert_ports` (#1915) </blockquote> ## `hugr-core` <blockquote> ## [0.14.4](hugr-core-v0.14.3...hugr-core-v0.14.4) - 2025-02-24 ### Bug Fixes - delegate default impls in HugrView (#1921) ### New Features - add xor to logic extension (#1911) - Add `Type::as_sum` and `SumType::variants`. (#1914) - Add `HugrMutInternals::insert_ports` (#1915) </blockquote> ## `hugr-llvm` <blockquote> ## [0.14.4](hugr-llvm-v0.14.3...hugr-llvm-v0.14.4) - 2025-02-24 ### New Features - add xor to logic extension (#1911) - *(hugr-llvm)* Add extension points to `PreludeCodegen` for customising string lowering (#1918) </blockquote> ## `hugr-passes` <blockquote> ## [0.14.3](hugr-passes-v0.14.2...hugr-passes-v0.14.3) - 2025-02-05 ### Bug Fixes - Export `RemoveDeadFuncsError` (#1883) - const-folding Module keeps at least "main" (#1901) ### Documentation - Fix deprecation warning messages (#1891) </blockquote> ## `hugr-cli` <blockquote> ## [0.14.1](hugr-cli-v0.14.0...hugr-cli-v0.14.1) - 2024-12-18 ### New Features - Print `hugr-cli`'s correct version when using '--version' (#1790) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RemoveDeadFuncsPassreturns this error, which was hidden inside a private module.Adds missing docs to the struct, and converts the tuple variant into a regular struct.