-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic refresh of Student topic tags to display topic resolution upon Instructor reply #53
Conversation
I took a look at your code and it looks good to me! Earlier I pulled from your branch and your feature works on my end as well :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks so clean and great to me! Working with the existing socket for auto refresh is such a great move haha. Checked and tested locally, ready for merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops didn't approve it earlier
Pull Request Test Coverage Report for Build 13581441589Details
💛 - Coveralls |
Context
Resolves issues #51 and #52. Addresses user stories for resolved/unresolved posts and instructor role indicator.
Description
Added new functions to trigger an automatic refresh of the topic tag when a Student topic is resolved by an Instructor reply.
Codebase Changes
src/topics/create.js
: InTopics.reply
calls newly added functionresolveTopic
which callsTopics.updateTopicTags
insrc/topics/tags.js
to swap theunresolved
tag for aresolved
tag. Then it triggers a websocket eventevent:topic_resolved
which activates a new listener inpublic/src/client/topic/events.js
public/src/client/topic/events.js
: Added functiononTopicResolved
which callsTag.updateTopicTags
inpublic/src/client/topic/tag.js
which updates the topic tags on the user end.test/topics.js
Additional Information
Test added to
test/topics.js
to address resolving of Student post.Ran lint and test and tested using the following steps.
User testing:
unresolved
tag should be automatically addedresolved
tag should be automatically added and theunresolved
tag should be automatically removed without requiring a manual page refreshCoverage after all topic resolution feature implementation:

Coverage after test added to test suite:
