Automatically tag Instructor/Student topics with resolution status upon post #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create Student group upon Install. Add membership checks for Instructors/Students groups. Upon post creation, tag with "instructor-post"/"unresolved" tags for Instructors/Students respectively.
jwjulie
changed the title
jwjulie
changed the title
yukiiii04
approved these changes
Feb 11, 2025
| await privileges.global.give(defaultPrivileges.concat(['groups:view:users:info']), 'Instructors'); | ||
| console.log('===000===000===GAVE INSTRUCTORS PERMS'); | ||
| await privileges.global.give(defaultPrivileges.concat([ | ||
| 'groups:ban', 'groups:upload:post:file']), 'Global Moderators'); | ||
| await privileges.global.give(['groups:view:users', 'groups:view:tags', 'groups:view:groups'], 'guests'); |
There was a problem hiding this comment.
I added in my working branch (yuki-polls-p2b) a statement similar to this that gives the "create-polls" privilege to all groups, but I don't think that is showing up with strictly 1 change. Here's the attached screenshot, let me know what you think about that (maybe we need to link for sprint 2).
This was
linked to
issues
Feb 11, 2025
Pull Request Test Coverage Report for Build 13250887416Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Resolves issues #30 and #27 and addresses #24. Addresses user stories for resolved/unresolved posts and instructor role indicator.
Description
Created Students group on installation. Dependent on Instructors group created in
add-role-groupsbranch. Add membership checks for Instructors/Students groups. Upon topic creation, tag with "instructor-post"/"unresolved" tags for Instructors/Students.Codebase Changes
src/install.js: FunctioncreateStudentsGroupinitializes Students group and privileges are given in the same file.src/privileges/users.js: FunctionsisInstructorandisStudentare group membership checks for users.src/user/index.js: Exports the membership functions as part of user.src/topics/create.js: ModifiesTopics.postto automatically add 'unresolved' and 'instructor-post' tags to topics when they are created by users in the 'Students' and 'Instructors' groups respectively.Additional Information
Ran lint and test and tested using the following steps.
User testing:
instructor-posttag should be automatically addedunresolvedtag should be automatically added