Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rust 1.24 support by locking down some versions #98

Closed
wants to merge 1 commit into from

Conversation

palfrey
Copy link

@palfrey palfrey commented Feb 25, 2020

Based off the versions that worked in the last good 1.24 build at https://travis-ci.org/BurntSushi/fst/jobs/468402724

@palfrey palfrey requested a review from BurntSushi February 25, 2020 22:43
@BurntSushi
Copy link
Owner

Could you say why you are submitting this PR? The fst binary is more of a debugging tool and I don't really have any desire for maintaining support for it on versions of Rust that were released ~2 years ago.

FWIW, I am working on a new release of fst that bumps the MSRV to at least Rust 1.39 and will be hopefully putting that out soon.

@palfrey
Copy link
Author

palfrey commented Feb 25, 2020

Mainly because I've been digging through the tools in awesome-rust that have broken builds and seeing what I can do to fix them TBH. If you've got no interest in this, then no worries, but I figured even after seeing the new version work it's useful as an interim measure maybe?

@BurntSushi
Copy link
Owner

Ah okay, just bad timing then. #96 will resolve this, and it also moves CI to GitHub Actions. Resolving this in the interim isn't that important. Thanks though!

@BurntSushi BurntSushi closed this Feb 25, 2020
@palfrey palfrey deleted the fix-1.24 branch February 26, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants