Fix memory leak in Python String reading

Fix Memory Leak in Python Array reading

Use upload-artifacts-v4
Use download-artifacts-v4

Author: Brandon-T

.github/workflows/build.yml

@@ -194,8 +194,10 @@ jobs:
 
     - name: 'Upload Artifacts - ${{ matrix.config.name }}'
       if: github.event_name == 'push'
-      uses: actions/upload-artifact@v2.0.1
+      uses: actions/upload-artifact@v4
       with:
+        overwrite: true
+        name: 'artifact-${{ matrix.config.name }}'
         path: '${{ github.workspace }}/cmake-build-release/${{ matrix.config.release }}'
 
   Release:
@@ -242,7 +244,15 @@ jobs:
 
     - name: Download Artifacts
       if: github.event_name == 'push'
-      uses: actions/download-artifact@v2
+      uses: actions/download-artifact@v4
+      with:
+        pattern: 'artifact-*'
+        path: 'artifact'
+        merge-multiple: true
+
+    - name: List Artifacts
+      run: |
+          ls artifact
 
     - name: Upload Autobuild
       if: github.event_name == 'push' && !startsWith(github.ref, 'refs/tags/v')

RemoteInput/Injection/Injector_Darwin.cxx

@@ -507,7 +507,7 @@ bool Injector::Inject(std::string module_path, std::int32_t pid, void* bootstrap
     //Retrieve a task port for the remote process..
     mach_port_t  remote_task = 0;
     mach_error_t err = task_for_pid(mach_task_self(), pid, &remote_task);
-    if (err == 5)
+    if (err == KERN_FAILURE)
     {
         fprintf(stderr, "Could not access task for pid %d. You probably need to add user to procmod group\n", pid);
         return false;

RemoteInput/Plugin/Python/PythonCommon_Templates.hxx

@@ -282,6 +282,7 @@ T from_python_object(PyObject* object)
             Py_ssize_t size = 0;
             char* buffer = nullptr;
             python->PyBytes_AsStringAndSize(utf8_string, &buffer, &size);
+            (python->Py_XDECREF)(utf8_string);
             return *buffer;
         }
         return -1;
@@ -329,6 +330,7 @@ T from_python_object(PyObject* object)
             Py_ssize_t size = 0;
             char* buffer = nullptr;
             python->PyBytes_AsStringAndSize(utf8_string, &buffer, &size);
+            (python->Py_XDECREF)(utf8_string);
             return std::string(buffer, size);
         }
         return std::string();
@@ -345,6 +347,7 @@ T from_python_object(PyObject* object)
             Py_ssize_t size = 0;
             char* buffer = nullptr;
             python->PyBytes_AsStringAndSize(utf8_string, &buffer, &size);
+            (python->Py_XDECREF)(utf8_string);
             return buffer;
         }
         return nullptr;
@@ -425,6 +428,8 @@ std::vector<T> from_python_array(PyObject* object)
                 result.push_back(from_python_object<T>(next));
             }
         }
+
+        (python->Py_DECREF)(iter);
     }
     return result;
 }