This repository was archived by the owner on Apr 28, 2023. It is now read-only.
Reverse swap flow #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned | @@ -59,3 +71,21 @@ export const toWholeCoins = satoshis => { | |||
| export const getCurrencyName = symbol => { | |||
| return symbol === 'BTC' ? 'Bitcoin' : 'Litecoin'; | |||
| }; | |||
|
|
|||
| // TODO: refactor how we copy | |||
There was a problem hiding this comment.
You can remove this TODO, its irrelevant.
There was a problem hiding this comment.
Sure? Why did you put it there in the first place?
There was a problem hiding this comment.
The implementation was off the top of my head at first so I wasn't sure if it would cover all use cases, but I don't think we need anything fancier than that.
ImmanuelSegol
approved these changes
Jan 13, 2019
ImmanuelSegol
suggested changes
Jan 13, 2019
There was a problem hiding this comment.
@michael1011 Solve the conflicts, but other then that looks very good.
michael1011
force-pushed
the
reverse-swap
branch
from
b42c44c to
4eb262d
Compare
|
Should be good now. Please have another look @ImmanuelSegol |
peartobear
approved these changes
Jan 14, 2019
ImmanuelSegol
approved these changes
Jan 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on BoltzExchange/boltz-middleware#32