This repository was archived by the owner on Apr 28, 2023. It is now read-only.
refactor: dont cache user input #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
I think @armurbalda specifically requested this feature. What about checking whether the cached user input is still valid when loading it?
|
michael1011
approved these changes
Apr 17, 2019
michael1011
reviewed
Apr 17, 2019
|
And don't forget to squash before merging this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #150
The issue @MikeD123 was talking about where he inputs incorrect data then refreshes and the data persist was due to caching of user input every time, this behavior seems unnecessary to me.
@michael1011 @peartobear Should we add a notification or something to recommend the users install joule? Personally, I don't think we should push a certain product and just make a nice list in the FAQ section. Or write a nice blog post about the options out there @michael1011 ;)