Fixed bug where navigating to a URL that is a partial match to the current base URL attempted in-SPA navigation (blackbaud#372)

Fixes blackbaud/skyux2#1559

Author: Blackbaud-PaulCrowder

src/app/app.component.spec.ts

@@ -200,6 +200,7 @@ describe('AppComponent', () => {
     };
     scrollCalled = false;
     viewport = new SkyAppViewportService();
+    navigateByUrlParams = undefined;
   });
 
   it('should create component', async(() => {
@@ -576,6 +577,26 @@ describe('AppComponent', () => {
     });
   }));
 
+  it('should handle global links that start with the same base URL as the SPA', async(() => {
+    let spyOmnibar = spyOn(BBOmnibar, 'load');
+
+    skyAppConfig.skyux.omnibar = {
+      experimental: true
+    };
+
+    skyAppConfig.skyux.host.url = 'base.com/';
+    skyAppConfig.runtime.app.base = 'custom-base/';
+
+    setup(skyAppConfig, false).then(() => {
+      fixture.detectChanges();
+      const cb = spyOmnibar.calls.first().args[0].nav.beforeNavCallback;
+
+      let globalLink = cb({ url: 'base.com/custom-base-2' });
+      expect(globalLink).toEqual(true);
+      expect(navigateByUrlParams).not.toBeDefined();
+    });
+  }));
+
   it('should use the original url casing if calling navigateByUrl', async(() => {
     let spyOmnibar = spyOn(BBOmnibar, 'load');
 

src/app/app.component.ts

@@ -158,7 +158,13 @@ export class AppComponent implements OnInit {
     nav.beforeNavCallback = (item: BBOmnibarNavigationItem) => {
       const url = item.url.toLowerCase();
 
-      if (url.indexOf(baseUrl) === 0) {
+      if (
+        url === baseUrl ||
+        // Make sure the base URL is not simply a partial match of the base URL plus additional
+        // characters after the base URL that are not "terminating" characters
+        url.indexOf(baseUrl + '/') === 0 ||
+        url.indexOf(baseUrl + '?') === 0
+      ) {
         const routePath = item.url.substring(baseUrl.length, url.length);
 
         // Since the omnibar is loaded outside Angular, navigating needs to be explicitly