Updated technique to test html-webpack-plugin. (blackbaud#191)

* Updated technique to test html-webpack-plugin.

* Updated Chromedriver version

* Refactored e2e's calling of chromedriver-manager-update so it can be called for Appveyor.

* Debugging

* Trying verbose logging

* More debugging

* Disabled verbose logging.  Trying Chrome beta.

* Trying firefox.

* Wrong file.

* Chrome on default dist.

* Installing Chrome.

* Trying additional flags.

* Trying just sandbox flag with bionic.

* Incorporated feedback.

* Updated to non pre-release version of chromedriver-version-matcher.

Author: Bobby Earl

.gitignore

@@ -47,3 +47,5 @@ yarn.lock
 *.iml
 *.ipr
 *.iws
+
+dist

.travis.yml

@@ -1,7 +1,7 @@
 os:
   - linux
   - osx
-  
+
 language: node_js
 dist: bionic
 

cli/e2e.js

@@ -4,18 +4,14 @@
 const fs = require('fs-extra');
 const glob = require('glob');
 const path = require('path');
-const spawn = require('cross-spawn');
 const selenium = require('selenium-standalone');
 const protractorLauncher = require('protractor/built/launcher');
 const logger = require('@blackbaud/skyux-logger');
-const matcher = require('chromedriver-version-matcher');
 
 const build = require('./utils/run-build');
 const server = require('./utils/server');
 const configResolver = require('./utils/config-resolver');
-
-// Disable this to quiet the output
-const spawnOptions = { stdio: 'inherit' };
+const chromeDriverManager = require('./utils/chromedriver-manager');
 
 let seleniumServer;
 let start;
@@ -56,25 +52,6 @@ function spawnProtractor(configPath, chunks, port, skyPagesConfig) {
   process.on('exit', killServers);
 }
 
-/**
- * Calls the getChromeDriverVersion method in our library, but handles any errors.
- */
-function getChromeDriverVersion() {
-  return new Promise(resolve => {
-    const defaultVersion = 'latest';
-
-    matcher.getChromeDriverVersion()
-      .then(result => {
-        if (result.chromeDriverVersion) {
-          resolve(result.chromeDriverVersion);
-        } else {
-          resolve(defaultVersion);
-        }
-      })
-      .catch(() => resolve(defaultVersion));
-  });
-}
-
 /**
  * Spawns the selenium server if directConnect is not enabled.
  * @name spawnSelenium
@@ -105,40 +82,9 @@ function spawnSelenium(configPath) {
 
     // Otherwise we need to prep protractor's selenium
     } else {
-
-      logger.info(`Getting webdriver version.`);
-
-      getChromeDriverVersion().then(version => {
-        logger.info(`Updating webdriver to version ${version}`);
-
-        const webdriverManagerPath = path.resolve(
-          'node_modules',
-          '.bin',
-          'webdriver-manager'
-        );
-
-        const results = spawn.sync(
-          webdriverManagerPath,
-          [
-            'update',
-            '--standalone',
-            'false',
-            '--gecko',
-            'false',
-            '--versions.chrome',
-            version
-          ],
-          spawnOptions
-        );
-
-        if (results.error) {
-          reject(results.error);
-          return;
-        }
-
-        logger.info('Selenium server is ready.');
-        resolve();
-      });
+      chromeDriverManager.update()
+        .then(() => resolve())
+        .catch(err => reject(err));
     }
   });
 }

cli/utils/chromedriver-manager.js

@@ -0,0 +1,69 @@
+/*jslint node: true */
+'use strict';
+
+const path = require('path');
+const spawn = require('cross-spawn');
+const logger = require('@blackbaud/skyux-logger');
+const matcher = require('chromedriver-version-matcher');
+
+/**
+ * Calls the getChromeDriverVersion method in our library.
+ * Handles any errors and defaults to 'latest'.
+ */
+function getVersion() {
+  return new Promise(resolve => {
+    const defaultVersion = 'latest';
+
+    matcher.getChromeDriverVersion()
+      .then(result => {
+        if (result.chromeDriverVersion) {
+          resolve(result.chromeDriverVersion);
+        } else {
+          resolve(defaultVersion);
+        }
+      })
+      .catch(() => resolve(defaultVersion));
+  });
+}
+
+function update() {
+  return new Promise((resolve, reject) => {
+    getVersion().then(version => {
+      logger.info(`Updating webdriver to version ${version}`);
+
+      const webdriverManagerPath = path.resolve(
+        'node_modules',
+        '.bin',
+        'webdriver-manager'
+      );
+
+      const results = spawn.sync(
+        webdriverManagerPath,
+        [
+          'update',
+          '--standalone',
+          'false',
+          '--gecko',
+          'false',
+          '--versions.chrome',
+          version
+        ],
+        {
+          stdio: 'inherit'
+        }
+      );
+
+      if (results.error) {
+        reject(results.error);
+      } else {
+        logger.info('webdriver successfully updated.');
+        resolve();
+      }
+    });
+  });
+}
+
+module.exports = {
+  getVersion,
+  update
+};

config/protractor/protractor-dev.conf.js

@@ -113,7 +113,11 @@ if (process.env.TRAVIS) {
   config.capabilities = {
     browserName: 'chrome',
     'chromeOptions': {
-      'args': ['--disable-extensions --ignore-certificate-errors']
+      'args': [
+        '--disable-extensions',
+        '--ignore-certificate-errors',
+        '--no-sandbox'
+      ]
     }
   };
 }

package-lock.json

@@ -8,7 +8,7 @@
     "coverage:builder": "istanbul cover --report=html --dir=./coverage/builder ./node_modules/jasmine/bin/jasmine.js JASMINE_CONFIG_PATH=jasmine.json",
     "coverage:runtime": "node ./utils/cli-test.js dev-runtime",
     "coverage:src-app": "node ./utils/cli-test.js dev-src-app",
-    "e2e": "webdriver-manager update --standalone false --gecko false && npm run protractor",
+    "e2e": "node ./utils/cli-chromedriver-manager-update && npm run protractor",
     "protractor": "protractor ./config/protractor/protractor-dev.conf.js",
     "lint": "eslint -c .eslintrc.json cli config lib loader plugin utils index.js",
     "test": "npm run lint && npm run coverage && npm run e2e"
@@ -70,7 +70,7 @@
     "angular2-template-loader": "0.6.2",
     "async": "2.6.3",
     "awesome-typescript-loader": "5.2.1",
-    "chromedriver-version-matcher": "^1.0.0-alpha.2",
+    "chromedriver-version-matcher": "^1.0.0",
     "cors": "2.8.5",
     "cross-spawn": "6.0.5",
     "enhanced-resolve": "4.1.1",

package.json

@@ -2,10 +2,8 @@
 'use strict';
 
 const fs = require('fs-extra');
-const glob = require('glob');
 const path = require('path');
 const mock = require('mock-require');
-const spawn = require('cross-spawn');
 const selenium = require('selenium-standalone');
 const logger = require('@blackbaud/skyux-logger');
 
@@ -182,98 +180,32 @@ describe('cli e2e', () => {
 
   it('should catch protractor\'s selenium failures', (done) => {
 
+    const error = new Error('custom-error');
+
     mock('cross-spawn', {
       spawn: () => {
         return {
           on: () => { }
         };
-      },
-      sync: () => {
-        return {
-          error: new Error('Webdriver update failed.')
-        };
       }
     });
 
+    mock('../cli/utils/chromedriver-manager', {
+      update: () => Promise.reject(error)
+    });
+
     spyOn(process, 'exit').and.callFake(exitCode => {
       expect(exitCode).toEqual(1);
+      expect(logger.error).toHaveBeenCalledWith(error);
       done();
     });
 
     mock.reRequire('../cli/e2e')('e2e', ARGV, SKY_PAGES_CONFIG, WEBPACK);
   });
 
-  function webdriverManagerUpdate(version, expected, done) {
-
-    mock(configPath, {
-      config: { }
-    });
-
-    mock('../cli/utils/run-build', () => new Promise(resolve => {
-      resolve({
-        toJson: () => {
-          return {
-            chunks: CHUNKS
-          }
-        }
-      });
-    }));
-
-    mock('chromedriver-version-matcher', {
-      getChromeDriverVersion: () => {
-        if (version === undefined) {
-          return Promise.reject();
-        } else {
-          return Promise.resolve({
-            chromeDriverVersion: version
-          });
-        }
-      }
-    });
-
-    const spyCrossSpawnSync = jasmine.createSpy('sync').and.callFake(() => ({ error: '' }));
-    mock('cross-spawn', {
-      sync: spyCrossSpawnSync
-    });
-
-    spyOn(fs, 'existsSync').and.returnValue(true);
-
-    mock.reRequire('../cli/e2e')(
-      'e2e',
-      ARGV,
-      SKY_PAGES_CONFIG,
-      WEBPACK
-    );
-
-    spyOn(process, 'exit').and.callFake(() => {
-      expect(spyCrossSpawnSync.calls.argsFor(0)[1]).toEqual([
-        'update',
-        '--standalone',
-        'false',
-        '--gecko',
-        'false',
-        '--versions.chrome',
-        expected
-      ]);
-      done();
-    });
-  }
-
-  it('should run webdriver-manager update command with the required version', (done) => {
-    webdriverManagerUpdate('123', '123', done);
-  });
-
-  it('should run webdriver-manager update command with latest if no version found', (done) => {
-    webdriverManagerUpdate('', 'latest', done);
-  });
-
-  it('should run webdriver-manager update command with latest if finding version fails', (done) => {
-    webdriverManagerUpdate(undefined, 'latest', done);
-  });
-
   it('should not continue if no e2e spec files exist', (done) => {
     mock('glob', {
-      sync: path => []
+      sync: () => []
     });
 
     spyOn(process, 'exit').and.callFake(exitCode => {
@@ -318,7 +250,7 @@ describe('cli e2e', () => {
 
   it('should pass chunks from the build stats to selenium', (done) => {
     mock.reRequire('../cli/e2e')('e2e', ARGV, SKY_PAGES_CONFIG, WEBPACK);
-    spyOn(process, 'exit').and.callFake(exitCode => {
+    spyOn(process, 'exit').and.callFake(() => {
       expect(PROTRACTOR_CONFIG_ARGS.params.chunks).toEqual(CHUNKS);
       done();
     });