feat: move help logic into latest lib-help (blackbaud#190)

* feat: move help logic into latest lib-help

* feat: use 3.2.0 version of lib-help

* refactor: remove unused host var

Co-authored-by: Bobby Earl <bobby.earl@blackbaud.com>

Author: Blackbaud-ColbyWhite

package-lock.json

@@ -59,7 +59,7 @@
   "dependencies": {
     "@angular-devkit/build-optimizer": "0.13.9",
     "@blackbaud/help-client": "2.1.0",
-    "@blackbaud/skyux-lib-help": "3.1.2",
+    "@blackbaud/skyux-lib-help": "3.2.0",
     "@blackbaud/skyux-logger": "1.1.1",
     "@ngtools/webpack": "7.3.9",
     "@pact-foundation/karma-pact": "2.2.0",

package.json

@@ -705,71 +705,6 @@ describe('AppComponent', () => {
     });
   }));
 
-  it('should assign help config extends key to the svcid if one exists', async(() => {
-    const spyHelp = spyOn(mockHelpInitService, 'load');
-    const expectedCall = { productId: 'test-config', extends: 'help-extend' };
-    skyAppConfig.skyux.help = { productId: 'test-config' };
-
-    skyAppConfig.skyux.params = ['svcid'];
-    skyAppConfig.runtime.params.has = (key: any) => key === 'svcid';
-    skyAppConfig.runtime.params.get = (key: any) => key === 'svcid' ? 'help-extend' : false;
-
-    setup(skyAppConfig).then(() => {
-      fixture.detectChanges();
-      expect(spyHelp).not.toHaveBeenCalledWith(skyAppConfig.skyux.help);
-      expect(spyHelp).toHaveBeenCalledWith(expectedCall);
-    });
-  }));
-
-  it('should assign help config locale key if none exist and host exposes the browser language', async(() => {
-    const spyHelp = spyOn(mockHelpInitService, 'load');
-
-    skyAppConfig.runtime.params.has = (key: any) => key === false;
-
-    mockSkyuxHost = {
-      acceptLanguage: 'fr-ca'
-    };
-    const expectedCall = { productId: 'test-config', extends: 'bb-help', locale: mockSkyuxHost.acceptLanguage };
-    skyAppConfig.skyux.help = { productId: 'test-config', extends: 'bb-help' };
-
-    setup(skyAppConfig).then(() => {
-      fixture.detectChanges();
-      expect(spyHelp).not.toHaveBeenCalledWith(skyAppConfig.skyux.help);
-      expect(spyHelp).toHaveBeenCalledWith(expectedCall);
-    });
-  }));
-
-  it('should fallback to \'\' for the locale if SKYUX_HOST.acceptLanguage does not exist', async(() => {
-    const spyHelp = spyOn(mockHelpInitService, 'load');
-
-    skyAppConfig.runtime.params.has = (key: any) => key === false;
-
-    mockSkyuxHost = {};
-    const expectedCall = { productId: 'test-config', extends: 'bb-help', locale: '' };
-    skyAppConfig.skyux.help = { productId: 'test-config', extends: 'bb-help' };
-
-    setup(skyAppConfig).then(() => {
-      fixture.detectChanges();
-      expect(spyHelp).not.toHaveBeenCalledWith(skyAppConfig.skyux.help);
-      expect(spyHelp).toHaveBeenCalledWith(expectedCall);
-    });
-  }));
-
-  it('should not override a locale that has been passed into the config', async(() => {
-    const spyHelp = spyOn(mockHelpInitService, 'load');
-    mockSkyuxHost = {
-      acceptLanguage: 'fr-ca'
-    };
-    const expectedCall = { productId: 'test-config', extends: 'bb-help', locale: 'en-ga' };
-    skyAppConfig.skyux.help = { productId: 'test-config', extends: 'bb-help', locale: 'en-ga' };
-
-    setup(skyAppConfig).then(() => {
-      fixture.detectChanges();
-      expect(spyHelp).toHaveBeenCalledWith(skyAppConfig.skyux.help);
-      expect(spyHelp).toHaveBeenCalledWith(expectedCall);
-    });
-  }));
-
   it('should set isReady after SkyAppStyleLoader.loadStyles is resolved', async(() => {
     setup(skyAppConfig).then(() => {
       expect(comp.isReady).toEqual(true);

src/app/app.component.spec.ts

@@ -252,7 +252,6 @@ export class AppComponent implements OnInit, OnDestroy {
   private initShellComponents() {
     const omnibarConfig = this.config.skyux.omnibar;
     const helpConfig = this.config.skyux.help;
-    const skyuxHost = (this.windowRef.nativeWindow as any).SKYUX_HOST;
 
     const loadOmnibar = (args?: SkyAppOmnibarReadyArgs) => {
       this.setParamsFromQS(omnibarConfig);
@@ -294,15 +293,6 @@ export class AppComponent implements OnInit, OnDestroy {
       }
 
       if (helpConfig && this.helpInitService) {
-        if (this.config.runtime.params.has('svcid')) {
-          helpConfig.extends = this.config.runtime.params.get('svcid');
-        }
-
-        if (skyuxHost && !helpConfig.locale) {
-          const browserLanguages = skyuxHost.acceptLanguage || '';
-          helpConfig.locale = browserLanguages.split(',')[0];
-        }
-
         this.helpInitService.load(helpConfig);
       }
     }