Unit test assets (blackbaud#214)

* Updated configuration to point to assets.

* Removed leading slash (for Windows)

* Added test.

* Added test to bring branch coverage to 100%

* Fix windows test.

* Added comment and adjusted test for Windows.

Author: Bobby Earl

config/karma/shared.karma.conf.js

@@ -43,6 +43,10 @@ function getConfig(config) {
   const specStyles = `${__dirname}/../../utils/spec-styles.js`;
   const polyfillsBundle = `${__dirname}/../../src/polyfills.ts`;
 
+  // Used in conjunction with `proxies` property to remove 404 and correctly serve assets
+  // Karma normalizes the pattern before glob, so no need to accomodate different OSes.
+  const assetsPattern = `${srcPath}/assets/**`;
+
   const preprocessors = {};
 
   preprocessors[polyfillsBundle] = ['webpack'];
@@ -67,8 +71,16 @@ function getConfig(config) {
       {
         pattern: specStyles,
         watched: false
+      },
+      {
+        pattern: assetsPattern,
+        included: false,
+        served: true,
       }
     ],
+    proxies: {
+      '/~/': `/absolute${srcPath}`
+    },
     preprocessors: preprocessors,
     skyPagesConfig: skyPagesConfig,
     webpack: testWebpackConfig.getWebpackConfig(skyPagesConfig, argv),

test/config-karma-shared.spec.js

@@ -67,6 +67,23 @@ describe('config karma shared', () => {
     });
   });
 
+  it('should serve and proxy assets', (done) => {
+    const cwd = 'custom-cwd';
+    spyOn(process, 'cwd').and.returnValue(cwd);
+
+    mock.reRequire('../config/karma/shared.karma.conf')({
+      set: (config) => {
+        expect(config.files.pop()).toEqual({
+          pattern: path.join(cwd, 'src') + '/assets/**',
+          included: false,
+          served: true
+        });
+        expect(config.proxies['/~/']).toContain(`/absolute${cwd}`);
+        done();
+      }
+    });
+  });
+
   it('should ignore anything outside the src directory in webpackMiddleware', (done) => {
     mock('../config/sky-pages/sky-pages.config.js', {
       getSkyPagesConfig: () => ({

test/config-karma-test.spec.js

@@ -23,7 +23,7 @@ describe('config karma test', () => {
   });
 
   it('should load the shared config', (done) => {
-    require('../config/karma/test.karma.conf')({
+    mock.reRequire('../config/karma/test.karma.conf')({
       set: (config) => {
         expect(config.browsers).toBeDefined();
         expect(called).toEqual(true);
@@ -34,7 +34,7 @@ describe('config karma test', () => {
 
   it('should use a custom launcher for Travis', (done) => {
     process.env.TRAVIS = true;
-    require('../config/karma/test.karma.conf')({
+    mock.reRequire('../config/karma/test.karma.conf')({
       set: (config) => {
         expect(config.browsers[0]).toBe('Chrome_travis_ci');
         delete process.env.TRAVIS;
@@ -48,33 +48,50 @@ describe('config karma test', () => {
       headless: true
     };
 
-    require('../config/karma/test.karma.conf')({
+    mock.reRequire('../config/karma/test.karma.conf')({
       set: (config) => {
         expect(config.browsers[0]).toBe('ChromeHeadless');
         done();
       }
     });
   });
 
-  it('should include the desktop notifications reporter if --enableDesktopNotifications flag set', (done) => {
+  it('should include the desktop notifications reporter if --enableDesktopNotifications flag set without other reporters', (done) => {
     mockArgv = {
       enableDesktopNotifications: true
     };
 
-    require('../config/karma/test.karma.conf')({
+    mock.reRequire('../config/karma/test.karma.conf')({
       set: (config) => {
         expect(config.reporters).toContain('notify');
         done();
       }
     });
   });
 
+  it('should include the desktop notifications reporter if --enableDesktopNotifications flag set with other reporters', (done) => {
+    mockArgv = {
+      enableDesktopNotifications: true
+    };
+
+    mock(path, (config) => {
+      config.reporters = ['custom'];
+    });
+
+    mock.reRequire('../config/karma/test.karma.conf')({
+      set: (config) => {
+        expect(config.reporters).toEqual(['custom', 'notify']);
+        done();
+      }
+    });
+  });
+
   it('should configure the mochaReporter to ignoreSkipped if --suppressUnfocusedTestOutput flag set', (done) => {
     mockArgv = {
       suppressUnfocusedTestOutput: true
     };
 
-    require('../config/karma/test.karma.conf')({
+    mock.reRequire('../config/karma/test.karma.conf')({
       set: (config) => {
         expect(config.mochaReporter).toEqual({ ignoreSkipped: true });
         done();