Fixing the condition in orderItemRepository.countByVariant

christopherhero · christopherhero · commit 49e464a84414 · 2025-02-07T15:59:34.000+01:00
Fixing the condition in orderItemRepository.countByVariant
(caused incorrect calculations of units sold while elastic popualte)
diff --git a/src/Repository/OrderItemRepository.php b/src/Repository/OrderItemRepository.php
@@ -25,7 +25,7 @@ public function __construct(
 
     public function countByVariant(ProductVariantInterface $variant, array $orderStates = []): int
     {
-        if ([] !== $orderStates) {
+        if ([] === $orderStates) {
             $orderStates = [OrderInterface::STATE_CANCELLED, OrderInterface::STATE_CART];
         }
 

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ public function __construct(`
`25`	`25`
`26`	`26`	`public function countByVariant(ProductVariantInterface $variant, array $orderStates = []): int`
`27`	`27`	`{`
`28`		`- if ([] !== $orderStates) {`
	`28`	`+ if ([] === $orderStates) {`
`29`	`29`	`$orderStates = [OrderInterface::STATE_CANCELLED, OrderInterface::STATE_CART];`
`30`	`30`	`}`
`31`	`31`