Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for qc_check_complete.json file, and QC status "PASS" before symlinking #23

Closed
dfornika opened this issue Jan 18, 2024 · 0 comments · Fixed by #24
Closed

Check for qc_check_complete.json file, and QC status "PASS" before symlinking #23

dfornika opened this issue Jan 18, 2024 · 0 comments · Fixed by #24

Comments

@dfornika
Copy link
Member

We currently go ahead with symlinking a run if there is an upload_complete.json file in the run dir.

We've put in place a run-level QC checking system that writes a qc_check_complete.json file. That file includes information on the overall pass/fail status of the run. We'd like to only proceed with symlinking if the QC status is PASS.

We should also support other status codes like PASSED_MANUAL_REVIEW, for cases where the initial QC check was FAIL but we decided to allow analysis after manually reviewing the run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant