Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update text analytics api to v3 #916

Merged

Conversation

rohit21agrawal
Copy link
Contributor

No description provided.

@welcome
Copy link

welcome bot commented Aug 24, 2020

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. This helps us to create release messages and credit you for your hard work!
Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

Make sure to check out the developer guide for guidance on testing your change.

mhamilton723
mhamilton723 previously approved these changes Aug 24, 2020
Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #916 into master will decrease coverage by 1.14%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
- Coverage   85.30%   84.15%   -1.15%     
==========================================
  Files         189      189              
  Lines        8783     8791       +8     
  Branches      548      554       +6     
==========================================
- Hits         7492     7398      -94     
- Misses       1291     1393     +102     
Impacted Files Coverage Δ
...soft/ml/spark/cognitive/TextAnalyticsSchemas.scala 100.00% <ø> (ø)
...m/microsoft/ml/spark/cognitive/TextAnalytics.scala 85.58% <78.57%> (-1.80%) ⬇️
...m/microsoft/ml/spark/opencv/ImageTransformer.scala 49.25% <0.00%> (-47.77%) ⬇️
...cala/org/apache/spark/ml/param/ArrayMapParam.scala 7.69% <0.00%> (-46.16%) ⬇️
...rosoft/ml/spark/core/schema/BinaryFileSchema.scala 75.00% <0.00%> (-25.00%) ⬇️
...ala/com/microsoft/ml/spark/image/UnrollImage.scala 60.63% <0.00%> (-17.03%) ⬇️
...icrosoft/ml/spark/downloader/ModelDownloader.scala 80.00% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f92b09...ea8eb0b. Read the comment docs.

@rohit21agrawal rohit21agrawal marked this pull request as ready for review August 24, 2020 19:32
@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rohit21agrawal rohit21agrawal changed the title Update text analytics api to v3 feat: Update text analytics api to v3 Aug 25, 2020
@rohit21agrawal
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 916 in repo Azure/mmlspark

@rohit21agrawal
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rohit21agrawal
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rohit21agrawal
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rohit21agrawal
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're a wizard Rohit!

@rohit21agrawal rohit21agrawal merged commit 434fe5d into microsoft:master Aug 28, 2020
@welcome
Copy link

welcome bot commented Aug 28, 2020

Congrats on merging your first pull request, we appreciate your support! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants