-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve error message for invalid slot names #897
Merged
mhamilton723
merged 1 commit into
microsoft:master
from
imatiach-msft:ilmat/fix-bad-col-names
Aug 12, 2020
Merged
fix: improve error message for invalid slot names #897
mhamilton723
merged 1 commit into
microsoft:master
from
imatiach-msft:ilmat/fix-bad-col-names
Aug 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f234bd3
to
b0c130b
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #897 +/- ##
==========================================
+ Coverage 83.31% 85.16% +1.84%
==========================================
Files 189 189
Lines 8769 8783 +14
Branches 558 548 -10
==========================================
+ Hits 7306 7480 +174
+ Misses 1463 1303 -160
Continue to review full report at Codecov.
|
b0c130b
to
e4ba79c
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
e4ba79c
to
9849d1a
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: improve error message for invalid slot names
resolves
#887
related LightGBM code for special characters:
https://github.com/microsoft/LightGBM/blob/master/include/LightGBM/utils/common.h#L965