improvement: support numeric types (not just double) for weight/label #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaya-a
reviewed
Mar 7, 2020
src/main/scala/com/microsoft/ml/spark/vw/VowpalWabbitBase.scala
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #817 +/- ##
==========================================
- Coverage 85.25% 83.32% -1.94%
==========================================
Files 186 186
Lines 8560 8604 +44
Branches 498 505 +7
==========================================
- Hits 7298 7169 -129
- Misses 1262 1435 +173
Continue to review full report at Codecov.
|
fixed style (remove space *sigh*)
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
imatiach-msft
approved these changes
Mar 9, 2020
|
/azp run |
mhamilton723
approved these changes
Mar 9, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ocworld
pushed a commit
to AhnLab-OSS/mmlspark
that referenced
this pull request
Mar 24, 2020
…microsoft#817) * support numeric types (not just double) for weight/label * added warning when casting double to float fixed style (remove space *sigh*)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #808
close #804