Skip to content

Commit e4f695b

Browse files
nilekhcnilekhc
authored
chore: updates lint (#212)
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
1 parent 59a0d74 commit e4f695b

File tree

6 files changed

+280
-269
lines changed

6 files changed

+280
-269
lines changed

‎cmd/server/main.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ func main() {
8787
ProxyPort: *proxyPort,
8888
ConfigFilePath: *configFilePath,
8989
}
90-
kmsServer, err := plugin.New(ctx, pc)
90+
kmsServer, err := plugin.New(pc)
9191
if err != nil {
9292
klog.ErrorS(err, "failed to create server")
9393
os.Exit(1)

‎pkg/plugin/healthz.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func (h *HealthZ) Serve() {
4848
}
4949
}
5050

51-
func (h *HealthZ) ServeHTTP(w http.ResponseWriter, r *http.Request) {
51+
func (h *HealthZ) ServeHTTP(w http.ResponseWriter, _ *http.Request) {
5252
klog.V(5).Info("Started health check")
5353
ctx, cancel := context.WithTimeout(context.Background(), h.RPCTimeout)
5454
defer cancel()

‎pkg/plugin/mock_keyvault/keyvault_mock.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ type KeyVaultClient struct {
1919
decryptErr error
2020
}
2121

22-
func (kvc *KeyVaultClient) Encrypt(ctx context.Context, cipher []byte) ([]byte, error) {
22+
func (kvc *KeyVaultClient) Encrypt(_ context.Context, _ []byte) ([]byte, error) {
2323
kvc.mutex.Lock()
2424
defer kvc.mutex.Unlock()
2525
return kvc.encryptOut, kvc.encryptErr
2626
}
2727

28-
func (kvc *KeyVaultClient) Decrypt(ctx context.Context, plain []byte) ([]byte, error) {
28+
func (kvc *KeyVaultClient) Decrypt(_ context.Context, _ []byte) ([]byte, error) {
2929
kvc.mutex.Lock()
3030
defer kvc.mutex.Unlock()
3131
return kvc.decryptOut, kvc.decryptErr

‎pkg/plugin/server.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ type Config struct {
3535
}
3636

3737
// New creates an instance of the KMS Service Server.
38-
func New(ctx context.Context, pc *Config) (*KeyManagementServiceServer, error) {
38+
func New(pc *Config) (*KeyManagementServiceServer, error) {
3939
cfg, err := config.GetAzureConfig(pc.ConfigFilePath)
4040
if err != nil {
4141
return nil, err
@@ -51,7 +51,7 @@ func New(ctx context.Context, pc *Config) (*KeyManagementServiceServer, error) {
5151
}
5252

5353
// Version of kms
54-
func (s *KeyManagementServiceServer) Version(ctx context.Context, request *k8spb.VersionRequest) (*k8spb.VersionResponse, error) {
54+
func (s *KeyManagementServiceServer) Version(_ context.Context, _ *k8spb.VersionRequest) (*k8spb.VersionResponse, error) {
5555
return &k8spb.VersionResponse{
5656
Version: version.APIVersion,
5757
RuntimeName: version.Runtime,

‎tools/go.mod

+79-75
Original file line numberDiff line numberDiff line change
@@ -2,65 +2,67 @@ module github.com/Azure/kubernetes-kms/tools
22

33
go 1.19
44

5-
require github.com/golangci/golangci-lint v1.49.0
5+
require github.com/golangci/golangci-lint v1.52.2
66

77
require (
8-
4d63.com/gochecknoglobals v0.1.0 // indirect
9-
github.com/Antonboom/errname v0.1.7 // indirect
10-
github.com/Antonboom/nilnil v0.1.1 // indirect
11-
github.com/BurntSushi/toml v1.2.0 // indirect
8+
4d63.com/gocheckcompilerdirectives v1.2.1 // indirect
9+
4d63.com/gochecknoglobals v0.2.1 // indirect
10+
github.com/Abirdcfly/dupword v0.0.11 // indirect
11+
github.com/Antonboom/errname v0.1.9 // indirect
12+
github.com/Antonboom/nilnil v0.1.3 // indirect
13+
github.com/BurntSushi/toml v1.2.1 // indirect
1214
github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24 // indirect
1315
github.com/GaijinEntertainment/go-exhaustruct/v2 v2.3.0 // indirect
1416
github.com/Masterminds/semver v1.5.0 // indirect
15-
github.com/OpenPeeDeeP/depguard v1.1.0 // indirect
17+
github.com/OpenPeeDeeP/depguard v1.1.1 // indirect
1618
github.com/alexkohler/prealloc v1.0.0 // indirect
1719
github.com/alingse/asasalint v0.0.11 // indirect
18-
github.com/ashanbrown/forbidigo v1.3.0 // indirect
20+
github.com/ashanbrown/forbidigo v1.5.1 // indirect
1921
github.com/ashanbrown/makezero v1.1.1 // indirect
2022
github.com/beorn7/perks v1.0.1 // indirect
2123
github.com/bkielbasa/cyclop v1.2.0 // indirect
2224
github.com/blizzy78/varnamelen v0.8.0 // indirect
23-
github.com/bombsimon/wsl/v3 v3.3.0 // indirect
24-
github.com/breml/bidichk v0.2.3 // indirect
25-
github.com/breml/errchkjson v0.3.0 // indirect
25+
github.com/bombsimon/wsl/v3 v3.4.0 // indirect
26+
github.com/breml/bidichk v0.2.4 // indirect
27+
github.com/breml/errchkjson v0.3.1 // indirect
2628
github.com/butuzov/ireturn v0.1.1 // indirect
2729
github.com/cespare/xxhash/v2 v2.1.2 // indirect
28-
github.com/charithe/durationcheck v0.0.9 // indirect
29-
github.com/chavacava/garif v0.0.0-20220630083739-93517212f375 // indirect
30-
github.com/curioswitch/go-reassign v0.1.2 // indirect
31-
github.com/daixiang0/gci v0.6.3 // indirect
30+
github.com/charithe/durationcheck v0.0.10 // indirect
31+
github.com/chavacava/garif v0.0.0-20230227094218-b8c73b2037b8 // indirect
32+
github.com/curioswitch/go-reassign v0.2.0 // indirect
33+
github.com/daixiang0/gci v0.10.1 // indirect
3234
github.com/davecgh/go-spew v1.1.1 // indirect
3335
github.com/denis-tingaikin/go-header v0.4.3 // indirect
3436
github.com/esimonov/ifshort v1.0.4 // indirect
3537
github.com/ettle/strcase v0.1.1 // indirect
36-
github.com/fatih/color v1.13.0 // indirect
38+
github.com/fatih/color v1.15.0 // indirect
3739
github.com/fatih/structtag v1.2.0 // indirect
3840
github.com/firefart/nonamedreturns v1.0.4 // indirect
3941
github.com/fsnotify/fsnotify v1.5.4 // indirect
4042
github.com/fzipp/gocyclo v0.6.0 // indirect
41-
github.com/go-critic/go-critic v0.6.4 // indirect
42-
github.com/go-toolsmith/astcast v1.0.0 // indirect
43-
github.com/go-toolsmith/astcopy v1.0.1 // indirect
44-
github.com/go-toolsmith/astequal v1.0.2 // indirect
45-
github.com/go-toolsmith/astfmt v1.0.0 // indirect
46-
github.com/go-toolsmith/astp v1.0.0 // indirect
47-
github.com/go-toolsmith/strparse v1.0.0 // indirect
48-
github.com/go-toolsmith/typep v1.0.2 // indirect
49-
github.com/go-xmlfmt/xmlfmt v0.0.0-20191208150333-d5b6f63a941b // indirect
43+
github.com/go-critic/go-critic v0.7.0 // indirect
44+
github.com/go-toolsmith/astcast v1.1.0 // indirect
45+
github.com/go-toolsmith/astcopy v1.1.0 // indirect
46+
github.com/go-toolsmith/astequal v1.1.0 // indirect
47+
github.com/go-toolsmith/astfmt v1.1.0 // indirect
48+
github.com/go-toolsmith/astp v1.1.0 // indirect
49+
github.com/go-toolsmith/strparse v1.1.0 // indirect
50+
github.com/go-toolsmith/typep v1.1.0 // indirect
51+
github.com/go-xmlfmt/xmlfmt v1.1.2 // indirect
5052
github.com/gobwas/glob v0.2.3 // indirect
5153
github.com/gofrs/flock v0.8.1 // indirect
5254
github.com/golang/protobuf v1.5.2 // indirect
5355
github.com/golangci/check v0.0.0-20180506172741-cfe4005ccda2 // indirect
5456
github.com/golangci/dupl v0.0.0-20180902072040-3e9179ac440a // indirect
5557
github.com/golangci/go-misc v0.0.0-20220329215616-d24fe342adfe // indirect
56-
github.com/golangci/gofmt v0.0.0-20190930125516-244bba706f1a // indirect
58+
github.com/golangci/gofmt v0.0.0-20220901101216-f2edd75033f2 // indirect
5759
github.com/golangci/lint-1 v0.0.0-20191013205115-297bf364a8e0 // indirect
5860
github.com/golangci/maligned v0.0.0-20180506175553-b1d89398deca // indirect
59-
github.com/golangci/misspell v0.3.5 // indirect
61+
github.com/golangci/misspell v0.4.0 // indirect
6062
github.com/golangci/revgrep v0.0.0-20220804021717-745bb2f7c2e6 // indirect
6163
github.com/golangci/unconvert v0.0.0-20180507085042-28b1c447d1f4 // indirect
62-
github.com/google/go-cmp v0.5.8 // indirect
63-
github.com/gordonklaus/ineffassign v0.0.0-20210914165742-4cc7213b9bc8 // indirect
64+
github.com/google/go-cmp v0.5.9 // indirect
65+
github.com/gordonklaus/ineffassign v0.0.0-20230107090616-13ace0543b28 // indirect
6466
github.com/gostaticanalysis/analysisutil v0.7.1 // indirect
6567
github.com/gostaticanalysis/comment v1.4.2 // indirect
6668
github.com/gostaticanalysis/forcetypeassert v0.1.0 // indirect
@@ -70,82 +72,84 @@ require (
7072
github.com/hashicorp/go-version v1.6.0 // indirect
7173
github.com/hashicorp/hcl v1.0.0 // indirect
7274
github.com/hexops/gotextdiff v1.0.3 // indirect
73-
github.com/inconshreveable/mousetrap v1.0.0 // indirect
75+
github.com/inconshreveable/mousetrap v1.0.1 // indirect
7476
github.com/jgautheron/goconst v1.5.1 // indirect
7577
github.com/jingyugao/rowserrcheck v1.1.1 // indirect
7678
github.com/jirfag/go-printf-func-name v0.0.0-20200119135958-7558a9eaa5af // indirect
7779
github.com/julz/importas v0.1.0 // indirect
78-
github.com/kisielk/errcheck v1.6.2 // indirect
80+
github.com/junk1tm/musttag v0.5.0 // indirect
81+
github.com/kisielk/errcheck v1.6.3 // indirect
7982
github.com/kisielk/gotool v1.0.0 // indirect
83+
github.com/kkHAIKE/contextcheck v1.1.4 // indirect
8084
github.com/kulti/thelper v0.6.3 // indirect
8185
github.com/kunwardeep/paralleltest v1.0.6 // indirect
82-
github.com/kyoh86/exportloopref v0.1.8 // indirect
86+
github.com/kyoh86/exportloopref v0.1.11 // indirect
8387
github.com/ldez/gomoddirectives v0.2.3 // indirect
84-
github.com/ldez/tagliatelle v0.3.1 // indirect
85-
github.com/leonklingele/grouper v1.1.0 // indirect
88+
github.com/ldez/tagliatelle v0.4.0 // indirect
89+
github.com/leonklingele/grouper v1.1.1 // indirect
8690
github.com/lufeee/execinquery v1.2.1 // indirect
8791
github.com/magiconair/properties v1.8.6 // indirect
88-
github.com/maratori/testpackage v1.1.0 // indirect
89-
github.com/matoous/godox v0.0.0-20210227103229-6504466cf951 // indirect
92+
github.com/maratori/testableexamples v1.0.0 // indirect
93+
github.com/maratori/testpackage v1.1.1 // indirect
94+
github.com/matoous/godox v0.0.0-20230222163458-006bad1f9d26 // indirect
9095
github.com/mattn/go-colorable v0.1.13 // indirect
91-
github.com/mattn/go-isatty v0.0.16 // indirect
96+
github.com/mattn/go-isatty v0.0.17 // indirect
9297
github.com/mattn/go-runewidth v0.0.9 // indirect
9398
github.com/matttproud/golang_protobuf_extensions v1.0.1 // indirect
9499
github.com/mbilski/exhaustivestruct v1.2.0 // indirect
95-
github.com/mgechev/revive v1.2.3 // indirect
100+
github.com/mgechev/revive v1.3.1 // indirect
96101
github.com/mitchellh/go-homedir v1.1.0 // indirect
97102
github.com/mitchellh/mapstructure v1.5.0 // indirect
98-
github.com/moricho/tparallel v0.2.1 // indirect
103+
github.com/moricho/tparallel v0.3.1 // indirect
99104
github.com/nakabonne/nestif v0.3.1 // indirect
100105
github.com/nbutton23/zxcvbn-go v0.0.0-20210217022336-fa2cb2858354 // indirect
101-
github.com/nishanths/exhaustive v0.8.1 // indirect
106+
github.com/nishanths/exhaustive v0.9.5 // indirect
102107
github.com/nishanths/predeclared v0.2.2 // indirect
108+
github.com/nunnatsa/ginkgolinter v0.9.0 // indirect
103109
github.com/olekukonko/tablewriter v0.0.5 // indirect
104110
github.com/pelletier/go-toml v1.9.5 // indirect
105-
github.com/pelletier/go-toml/v2 v2.0.2 // indirect
106-
github.com/phayes/checkstyle v0.0.0-20170904204023-bfd46e6a821d // indirect
107-
github.com/pkg/errors v0.9.1 // indirect
111+
github.com/pelletier/go-toml/v2 v2.0.5 // indirect
108112
github.com/pmezard/go-difflib v1.0.0 // indirect
109-
github.com/polyfloyd/go-errorlint v1.0.2 // indirect
113+
github.com/polyfloyd/go-errorlint v1.4.0 // indirect
110114
github.com/prometheus/client_golang v1.12.1 // indirect
111115
github.com/prometheus/client_model v0.2.0 // indirect
112116
github.com/prometheus/common v0.32.1 // indirect
113117
github.com/prometheus/procfs v0.7.3 // indirect
114-
github.com/quasilyte/go-ruleguard v0.3.17 // indirect
115-
github.com/quasilyte/gogrep v0.0.0-20220120141003-628d8b3623b5 // indirect
116-
github.com/quasilyte/regex/syntax v0.0.0-20200407221936-30656e2c4a95 // indirect
118+
github.com/quasilyte/go-ruleguard v0.3.19 // indirect
119+
github.com/quasilyte/gogrep v0.5.0 // indirect
120+
github.com/quasilyte/regex/syntax v0.0.0-20210819130434-b3f0c404a727 // indirect
117121
github.com/quasilyte/stdinfo v0.0.0-20220114132959-f7386bf02567 // indirect
118-
github.com/ryancurrah/gomodguard v1.2.4 // indirect
119-
github.com/ryanrolds/sqlclosecheck v0.3.0 // indirect
120-
github.com/sanposhiho/wastedassign/v2 v2.0.6 // indirect
122+
github.com/ryancurrah/gomodguard v1.3.0 // indirect
123+
github.com/ryanrolds/sqlclosecheck v0.4.0 // indirect
124+
github.com/sanposhiho/wastedassign/v2 v2.0.7 // indirect
121125
github.com/sashamelentyev/interfacebloat v1.1.0 // indirect
122-
github.com/sashamelentyev/usestdlibvars v1.13.0 // indirect
123-
github.com/securego/gosec/v2 v2.13.1 // indirect
126+
github.com/sashamelentyev/usestdlibvars v1.23.0 // indirect
127+
github.com/securego/gosec/v2 v2.15.0 // indirect
124128
github.com/shazow/go-diff v0.0.0-20160112020656-b6b7b6733b8c // indirect
125129
github.com/sirupsen/logrus v1.9.0 // indirect
126130
github.com/sivchari/containedctx v1.0.2 // indirect
127131
github.com/sivchari/nosnakecase v1.7.0 // indirect
128-
github.com/sivchari/tenv v1.7.0 // indirect
129-
github.com/sonatard/noctx v0.0.1 // indirect
130-
github.com/sourcegraph/go-diff v0.6.1 // indirect
132+
github.com/sivchari/tenv v1.7.1 // indirect
133+
github.com/sonatard/noctx v0.0.2 // indirect
134+
github.com/sourcegraph/go-diff v0.7.0 // indirect
131135
github.com/spf13/afero v1.8.2 // indirect
132136
github.com/spf13/cast v1.5.0 // indirect
133-
github.com/spf13/cobra v1.5.0 // indirect
137+
github.com/spf13/cobra v1.6.1 // indirect
134138
github.com/spf13/jwalterweatherman v1.1.0 // indirect
135139
github.com/spf13/pflag v1.0.5 // indirect
136140
github.com/spf13/viper v1.12.0 // indirect
137141
github.com/ssgreg/nlreturn/v2 v2.2.1 // indirect
138142
github.com/stbenjam/no-sprintf-host-port v0.1.1 // indirect
139-
github.com/stretchr/objx v0.4.0 // indirect
140-
github.com/stretchr/testify v1.8.0 // indirect
141-
github.com/subosito/gotenv v1.4.0 // indirect
142-
github.com/sylvia7788/contextcheck v1.0.6 // indirect
143-
github.com/tdakkota/asciicheck v0.1.1 // indirect
143+
github.com/stretchr/objx v0.5.0 // indirect
144+
github.com/stretchr/testify v1.8.2 // indirect
145+
github.com/subosito/gotenv v1.4.1 // indirect
146+
github.com/t-yuki/gocover-cobertura v0.0.0-20180217150009-aaee18c8195c // indirect
147+
github.com/tdakkota/asciicheck v0.2.0 // indirect
144148
github.com/tetafro/godot v1.4.11 // indirect
145-
github.com/timakin/bodyclose v0.0.0-20210704033933-f49887972144 // indirect
146-
github.com/timonwong/logrlint v0.1.0 // indirect
147-
github.com/tomarrell/wrapcheck/v2 v2.6.2 // indirect
148-
github.com/tommy-muehle/go-mnd/v2 v2.5.0 // indirect
149+
github.com/timakin/bodyclose v0.0.0-20221125081123-e39cf3fc478e // indirect
150+
github.com/timonwong/loggercheck v0.9.4 // indirect
151+
github.com/tomarrell/wrapcheck/v2 v2.8.1 // indirect
152+
github.com/tommy-muehle/go-mnd/v2 v2.5.1 // indirect
149153
github.com/ultraware/funlen v0.0.3 // indirect
150154
github.com/ultraware/whitespace v0.0.5 // indirect
151155
github.com/uudashr/gocognit v1.0.6 // indirect
@@ -154,21 +158,21 @@ require (
154158
gitlab.com/bosi/decorder v0.2.3 // indirect
155159
go.uber.org/atomic v1.7.0 // indirect
156160
go.uber.org/multierr v1.6.0 // indirect
157-
go.uber.org/zap v1.17.0 // indirect
161+
go.uber.org/zap v1.24.0 // indirect
158162
golang.org/x/exp v0.0.0-20220722155223-a9213eeb770e // indirect
159-
golang.org/x/exp/typeparams v0.0.0-20220613132600-b0d781184e0d // indirect
160-
golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4 // indirect
161-
golang.org/x/sync v0.0.0-20220722155255-886fb9371eb4 // indirect
162-
golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab // indirect
163-
golang.org/x/text v0.3.8 // indirect
164-
golang.org/x/tools v0.1.12 // indirect
163+
golang.org/x/exp/typeparams v0.0.0-20230224173230-c95f2b4c22f2 // indirect
164+
golang.org/x/mod v0.9.0 // indirect
165+
golang.org/x/sync v0.1.0 // indirect
166+
golang.org/x/sys v0.6.0 // indirect
167+
golang.org/x/text v0.7.0 // indirect
168+
golang.org/x/tools v0.7.0 // indirect
165169
google.golang.org/protobuf v1.28.0 // indirect
166-
gopkg.in/ini.v1 v1.66.6 // indirect
170+
gopkg.in/ini.v1 v1.67.0 // indirect
167171
gopkg.in/yaml.v2 v2.4.0 // indirect
168172
gopkg.in/yaml.v3 v3.0.1 // indirect
169-
honnef.co/go/tools v0.3.3 // indirect
170-
mvdan.cc/gofumpt v0.3.1 // indirect
173+
honnef.co/go/tools v0.4.3 // indirect
174+
mvdan.cc/gofumpt v0.4.0 // indirect
171175
mvdan.cc/interfacer v0.0.0-20180901003855-c20040233aed // indirect
172176
mvdan.cc/lint v0.0.0-20170908181259-adc824a0674b // indirect
173-
mvdan.cc/unparam v0.0.0-20220706161116-678bad134442 // indirect
177+
mvdan.cc/unparam v0.0.0-20221223090309-7455f1af531d // indirect
174178
)

0 commit comments

Comments
 (0)