Fix error message in local traverser (issue #849) (#1713)

mohsha-msft · adreed-msft · web-flow · commit 6e2c8e71ac54 · 2022-03-16T21:07:10.000+05:30
* Log the failure to scan local files to help debugging

* return error trace as well.

Co-authored-by: Adele Reed &lt;adreed@microsoft.com&gt;
diff --git a/cmd/zc_traverser_local.go b/cmd/zc_traverser_local.go
@@ -29,6 +29,7 @@ import (
 	"path/filepath"
 	"strings"
 
+	"github.com/Azure/azure-pipeline-go/pipeline"
 	"github.com/Azure/azure-storage-azcopy/v10/common"
 	"github.com/Azure/azure-storage-azcopy/v10/common/parallel"
 )
@@ -305,7 +306,8 @@ func (t *localTraverser) Traverse(preprocessor objectMorpher, processor objectPr
 	singleFileInfo, isSingleFile, err := t.getInfoIfSingleFile()
 
 	if err != nil {
-		return fmt.Errorf("cannot scan the path %s, please verify that it is a valid", t.fullPath)
+		azcopyScanningLogger.Log(pipeline.LogError, fmt.Sprintf("Failed to scan path %s: %s", t.fullPath, err.Error()))
+		return fmt.Errorf("failed to scan path %s due to %s", t.fullPath, err.Error())
 	}
 
 	// if the path is a single file, then pass it through the filters and send to processor

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,7 @@ import (`
`29`	`29`	`"path/filepath"`
`30`	`30`	`"strings"`
`31`	`31`
	`32`	`+ "github.com/Azure/azure-pipeline-go/pipeline"`
`32`	`33`	`"github.com/Azure/azure-storage-azcopy/v10/common"`
`33`	`34`	`"github.com/Azure/azure-storage-azcopy/v10/common/parallel"`
`34`	`35`	`)`
`@@ -305,7 +306,8 @@ func (t *localTraverser) Traverse(preprocessor objectMorpher, processor objectPr`
`305`	`306`	`singleFileInfo, isSingleFile, err := t.getInfoIfSingleFile()`
`306`	`307`
`307`	`308`	`if err != nil {`
`308`		`- return fmt.Errorf("cannot scan the path %s, please verify that it is a valid", t.fullPath)`
	`309`	`+ azcopyScanningLogger.Log(pipeline.LogError, fmt.Sprintf("Failed to scan path %s: %s", t.fullPath, err.Error()))`
	`310`	`+ return fmt.Errorf("failed to scan path %s due to %s", t.fullPath, err.Error())`
`309`	`311`	`}`
`310`	`312`
`311`	`313`	`// if the path is a single file, then pass it through the filters and send to processor`