Enable lint (#1646)

* Enable Lint

* Enable Lint

* Enable Lint

* FIx Installation steps

* FIx Installation steps

* FIx Installation steps

* FIx Installation steps

* FIx Installation steps

* FIx Installation steps

* FIx Installation steps

* Install lint using go get

* Install lint using go get

* Install lint using go get

* Install lint using go get

* Install lint using go get

* Install lint using go get

* Install lint using curl

* Removing unused code

* Removing unused code

* Removing unused code

* Removing unused code

* Removing unused code

* Removing unused code

* Removing unused code

* Removing unused code

* Updated dependencies

* Unused code.

* Adding vet

* Go vet

* Go vet

Author: mohsha-msft

azure-pipelines.yml

@@ -11,6 +11,7 @@ pr:
       - main
 
 jobs:
+
   - job: Build
     timeoutInMinutes: 360
     strategy:
@@ -25,8 +26,26 @@ jobs:
       vmImage: $(imageName)
     steps:
       - task: GoTool@0
+        env:
+          GO111MODULE: 'on'
         inputs:
           version: '1.16'
+
+      - script: |
+          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.43.0
+          echo 'Installation complete' 
+          ./bin/golangci-lint --version 
+          ./bin/golangci-lint run e2etest
+        displayName: 'Golang Lint Check - Linux'
+        workingDirectory: $(System.DefaultWorkingDirectory)
+        condition: eq(variables.type, 'linux')
+
+      - script: |
+          echo 'Running GO Vet'
+          go vet 
+        displayName: 'Golang Vet - Linux'
+        workingDirectory: $(System.DefaultWorkingDirectory)
+
       - script: |
           GOARCH=amd64 GOOS=linux go build -o "$(Build.ArtifactStagingDirectory)/azcopy_linux_amd64"
           GOARCH=amd64 GOOS=linux go build -tags "se_integration" -o "$(Build.ArtifactStagingDirectory)/azcopy_linux_se_amd64"

e2etest/declarativeHelpers.go

@@ -51,6 +51,7 @@ func equals() comparison {
 	return comparison{true}
 }
 
+//nolint
 func notEquals() comparison {
 	return comparison{false}
 }

e2etest/declarativeResourceManagers.go

@@ -44,6 +44,7 @@ type downloadContentOptions struct {
 	downloadFileContentOptions
 }
 
+//nolint
 type downloadBlobContentOptions struct {
 	containerURL azblob.ContainerURL
 	cpkInfo      common.CpkInfo

e2etest/declarativeRunner.go

@@ -35,7 +35,7 @@ import (
 
 // RunScenarios is the key entry point for declarative testing.
 // It constructs and executes scenarios (subtest in Go-speak), according to its parameters, and checks their results
-func 	RunScenarios(
+func RunScenarios(
 	t *testing.T,
 	operations Operation,
 	testFromTo TestFromTo,

e2etest/declarativeScenario.go

@@ -351,7 +351,7 @@ func (s *scenario) validateProperties() {
 			// TODO: JohnR: need to remove the strip top dir prefix from the map (and normalize the delimiters)
 			//    since currently uploads fail here
 			var rawPaths []string
-			for rawPath, _ := range destProps {
+			for rawPath := range destProps {
 				rawPaths = append(rawPaths, rawPath)
 			}
 			s.a.Error(fmt.Sprintf("could not find expected file %s in keys %v", destName, rawPaths))
@@ -538,6 +538,7 @@ func (s *scenario) validateLastWriteTime(expected, actual *time.Time) {
 		expected, actual))
 }
 
+//nolint
 func (s *scenario) validateSMBAttrs(expected, actual *uint32) {
 	if expected == nil {
 		// These properties were not explicitly stated for verification

e2etest/declarativeTestFiles.go

@@ -123,7 +123,7 @@ func (op objectProperties) DeepCopy() objectProperties {
 	ret.isFolder = op.isFolder
 
 	if op.size != nil {
-		val := *&op.size
+		val := op.size
 		ret.size = val
 	}
 

e2etest/declarativeWithPropertyProviders.go

@@ -173,10 +173,12 @@ func (w with) createObjectProperties() *objectProperties {
 // use createOnly if you want to define properties that should be used when creating an object, but not
 // used when verifying the state of the transferred object. Generally you'll have no use for this.
 // Just use "with", and the test framework will do the right thing.
+//nolint
 type createOnly struct {
 	with
 }
 
+//nolint
 func (createOnly) appliesToVerification() bool {
 	return false
 }

e2etest/factory.go

@@ -241,6 +241,7 @@ func getTestName(t *testing.T) (pseudoSuite, test string) {
 	return pseudoSuite, removeUnderscores(testName)
 }
 
+//nolint
 // This function generates an entity name by concatenating the passed prefix,
 // the name of the test requesting the entity name, and the minute, second, and nanoseconds of the call.
 // This should make it easy to associate the entities with their test, uniquely identify
@@ -271,6 +272,7 @@ func (TestResourceNameGenerator) GenerateContainerName(c asserter) string {
 	return uuid.New().String()
 }
 
+//nolint
 func (TestResourceNameGenerator) generateBlobName(c asserter) string {
 	return generateName(c, blobPrefix, 0)
 }