-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added samples for timeout and retries #39867
base: main
Are you sure you want to change the base?
Added samples for timeout and retries #39867
Conversation
API change check API changes are not detected in this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @andrewmathew1
@@ -11,6 +11,18 @@ connecting to the socket. Default value is 5s. | |||
- `Read Timeout`: can be changed through `read_timeout` option. Changes the value on the client's http transport timeout when | |||
reading the service buffer stream, or receiving responses from the server. Default value is 65s. | |||
|
|||
These options can also be combined, as seen in the example below. | |||
This will set the client timeout to 10 seconds, connection timeout to 3 seconds, and read timeout to 60 seconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is client timeout end to end timeout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, client timeout is an absolute timeout for both the http request as well as processing the response. The connection timeout is the timeout for just the http request. This is also why the connection timeout must be smaller than the timeout parameter.
Description
Added samples to show users how to use the timeout and retries features in the SDK.
Also removed parameters in the Connection Retry Config section that are no longer being used.