Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TagsAreNotAllowedForProxyResource Incorrectly flagging patch request body as resource #742

Open
markcowl opened this issue Sep 9, 2024 · 1 comment

Comments

@markcowl
Copy link
Member

markcowl commented Sep 9, 2024

Describe the bug
Here is an example: https://github.com/Azure/azure-rest-api-specs-pr/pull/19477/checks?check_run_id=29850162346

In this case, a well-crafted PATCH request body for a tracked resource is flagged as an instance of a proxy resource with a Tags property. Obviously, this is not a resource and this should produce no violation.

To Reproduce
Steps to reproduce the behavior: https://github.com/Azure/azure-rest-api-specs-pr/pull/19477/checks?check_run_id=29850162346

Expected behavior
This rule should not have dtected this as a resource - the schema is only used in PATCH request body and not in PUT or as the response of any crud operation over the resource.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):
n/a This is simply a rules violation

Additional context
Add any other context about the problem here.

@mikeharder
Copy link
Member

@markcowl: This might be a dup or closely related to #741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants