fix(Get-AzureConstants.py): remove the date string from the header

* add test to circle config
* add make target to run test in test.mk
* add script that executes the test

update azure-const.sh to do an azure login

add client_id and client_secret vars to test run

Author: Jonathan Chauncey

.circleci/config.yml

@@ -13,13 +13,19 @@ jobs:
           GOPATH: /go
     steps:
       - checkout
-      - run: echo 'export PATH=$GOPATH/bin:$PATH' >> $BASH_ENV
+      - run: |
+          echo 'export PATH=$GOPATH/bin:$PATH' >> $BASH_ENV
+          echo 'export CLIENT_ID=${CLUSTER_SERVICE_PRINCIPAL_CLIENT_ID}' >> $BASH_ENV
+          echo 'export CLIENT_SECRET=${CLUSTER_SERVICE_PRINCIPAL_CLIENT_SECRET}' >> $BASH_ENV
       - run:
           name: Install dependencies
           command: make bootstrap
       - run:
           name: Run linting rules
           command: make test-style
+      - run:
+          name: Test Azure Constants
+          command: make test-azure-constants
       - run:
           name: Build binaries
           command: make build-binary

Makefile

@@ -48,6 +48,10 @@ dev:
 generate: bootstrap
 	go generate $(GOFLAGS) -v `glide novendor | xargs go list`
 
+.PHONY: generate-azure-constants
+generate-azure-constants:
+	python pkg/acsengine/Get-AzureConstants.py
+
 .PHONY: build
 build: generate
 	GOBIN=$(BINDIR) $(GO) install $(GOFLAGS) -ldflags '$(LDFLAGS)'

pkg/acsengine/Get-AzureConstants.py

@@ -67,7 +67,7 @@ def getStorageAccountType(sizeName):
 def getFileContents(dcosMasterMap, masterAgentMap, kubernetesAgentMap, sizeMap, locations):
     text = r"""package acsengine
 
-// AUTOGENERATED FILE - last generated """ + time
+// AUTOGENERATED FILE """
 
     text += r"""
 

pkg/acsengine/azureconst.go

@@ -1,6 +1,6 @@
 package acsengine
 
-// AUTOGENERATED FILE - last generated 2017-10-26 03:04:32
+// AUTOGENERATED FILE
 
 // AzureLocations provides all azure regions in prod.
 // Related powershell to refresh this list:

scripts/azure-const.sh

@@ -0,0 +1,39 @@
+#!/bin/bash
+if [ -z "$CLIENT_ID" ]; then
+    echo "must provide a CLIENT_ID env var"
+    exit 1;
+fi
+
+if [ -z "$CLIENT_SECRET" ]; then
+    echo "must provide a CLIENT_SECRET env var"
+    exit 1;
+fi
+
+if [ -z "$TENANT_ID" ]; then
+    echo "must provide a TENANT_ID env var"
+    exit 1;
+fi
+
+if [ -z "$SUBSCRIPTION_ID" ]; then
+    echo "must provide a SUBSCRIPTION_ID env var"
+    exit 1;
+fi
+
+az login --service-principal \
+		--username "${CLIENT_ID}" \
+		--password "${CLIENT_SECRET}" \
+		--tenant "${TENANT_ID}" &>/dev/null
+
+# set to the sub id we want to cleanup
+az account set -s $SUBSCRIPTION_ID
+
+python pkg/acsengine/Get-AzureConstants.py
+git status | grep pkg/acsengine/azureconst.go
+exit_code=$?
+if [ $exit_code -gt "0" ]; then
+  echo "No modifications found! Exiting 0"
+  exit 0
+else
+  echo "File was modified! Exiting 1"
+  exit 1
+fi 

test.mk

@@ -26,4 +26,7 @@ test-kubernetes:
 	@ORCHESTRATOR=kubernetes go run ./test/e2e/runner.go
 
 test-dcos:
-	@ORCHESTRATOR=dcos go run ./test/e2e/runner.go
+	@ORCHESTRATOR=dcos go run ./test/e2e/runner.go
+
+test-azure-constants:
+	./scripts/azure-const.sh