Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Commit 762984a

Browse files
authored
stop running make coverage + make test (#2009)
it’s re-running unit tests
1 parent b7e5093 commit 762984a

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

.circleci/config.yml

-3
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,6 @@ jobs:
3131
command: make test
3232
- store_test_results:
3333
path: test/junit
34-
- run:
35-
name: Generate test coverage results
36-
command: make coverage
3734
swarm-e2e:
3835
working_directory: /go/src/github.com/Azure/acs-engine
3936
docker:

scripts/ginkgo.coverage.sh

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ profile="${coverdir}/cover.out"
2323
hash goveralls 2>/dev/null || go get github.com/mattn/goveralls
2424
hash godir 2>/dev/null || go get github.com/Masterminds/godir
2525

26+
# TODO this appears to run all unit tests, rather than just generate coverage data
2627
generate_cover_data() {
2728
ginkgo -skipPackage test/e2e -cover -r .
2829
find . -type f -name "*.coverprofile" | while read -r file; do mv $file ${coverdir}; done

0 commit comments

Comments
 (0)