Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Commit 4ea84d0

Browse files
authored
Fix make generate slowness on Docker for Mac (#1226)
* fix(docker): add .git to the repo. needed for acs-engine version and dev workflow * fix(generate): replace slow `go list ...` with `glide novendor`
1 parent e8b10c7 commit 4ea84d0

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

.dockerignore

-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
./acs-engine
22
./acs-engine.exe
33
./_output
4-
./.git
54
./test/acs-engine-test/acs-engine-test
65
## autogenerated
76
./pkg/i18n/translations.go

Makefile

+1-5
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,7 @@ BINDIR := $(CURDIR)/bin
1515
BINARIES := acs-engine
1616
VERSION := $(shell git rev-parse HEAD)
1717

18-
# this isn't particularly pleasant, but it works with the least amount
19-
# of requirements around $GOPATH. The extra sed is needed because `gofmt`
20-
# operates on paths, go list returns package names, and `go fmt` always rewrites
21-
# which is not what we need to do in the `test_fmt` target.
22-
GOFILES=`go list ./... | grep -v "github.com/Azure/acs-engine/vendor" | sed 's|github.com/Azure/acs-engine|.|g' | grep -v -w '^.$$'`
18+
GOFILES=`glide novendor | xargs go list`
2319

2420
all: build
2521

0 commit comments

Comments
 (0)