Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compute_logderivative_inverse based on ProvingKey and not ProverPolynomials (AllEntities) #921

Open
lucasxia01 opened this issue Mar 20, 2024 · 4 comments

Comments

@lucasxia01
Copy link
Contributor

compute_logderivative_inverse seemingly creates the lookup_inverses polynomial and doesn't rely on shifts so it could be possible to use a provingkey instead.

@maramihali
Copy link
Contributor

this can be closed by: AztecProtocol/aztec-packages#11140

@lucasxia01
Copy link
Contributor Author

how? it seems like compute_logderivative_inverse still takes in polynomials

@lucasxia01
Copy link
Contributor Author

this PR only adds a new compute_logderivative_inverses function that takes in a proving key, but doesn't address the actual function this issue is talking about

@maramihali
Copy link
Contributor

oh, right i see what you mean now - you'd prefer the input to be the proving key rather than polynomials, relation parameters and circuit size

@maramihali maramihali reopened this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants