fix: verify_honk_proof inputs generation in bootstrap #12457
+83
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasxia01
commented
Mar 6, 2025
| cd ../.. | ||
|
|
||
|
|
||
| # $bb OLD_API write_recursion_inputs_ultra_honk -b ./target/program.json -o ../verify_honk_proof --recursive |
There was a problem hiding this comment.
can delete these flows
lucasxia01
commented
Mar 6, 2025
| trap "rm -rf $outdir" EXIT | ||
| local key_hash="0x0000000000000000000000000000000000000000000000000000000000000000" | ||
|
|
||
| local prove_uh_cmd="$bb prove --scheme ultra_honk --init_kzg_accumulator --output_format fields --write_vk -o $outdir -b ./target/program.json -w ./target/witness.gz" |
There was a problem hiding this comment.
this as a whole is honestly a little more complicated than I would've liked... unclear if this that much better than the write_recursion_inputs_ultra_honk flows
There was a problem hiding this comment.
its probably easier to have all the logic here though instead of having to modify both bootstrap and cpp files, even if this is quite annoying logic to handle in bash/jq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes AztecProtocol/barretenberg#1279, fixing the acir test input generation workflow.
Closes AztecProtocol/barretenberg#1253, deprecating the write_recursion_inputs_ultra_honk flows.
Closes AztecProtocol/barretenberg#1285, adding support for generating double_verify_honk_proof inputs.
Reorders compilation so that we compile verify_honk_proof and verify_rollup_honk_proof only after compiling the rest of the programs and running write_recursion_inputs_honk to generate new Prover.tomls.
Also adds input generation for double_verify_honk_proof. This style of input generation is an easier flow for future updating.