Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vc): Use a different signature library for managing attestations #7965

Closed
Tracked by #7681
Maddiaa0 opened this issue Aug 14, 2024 · 2 comments
Closed
Tracked by #7681

Comments

@Maddiaa0
Copy link
Member

Overview

For the current prototype, we are using viems wallet libraries as our signing library ( for ecdsa signatures over k1 ). Viem offers no raw signing abilities, and such all messages, even if 32 bytes are hashed again. And everything is dealt with in strings by default - generally not the vibe

@jxom
Copy link

jxom commented Aug 15, 2024

Viem offers no raw signing abilities

This is not true. See raw here: https://viem.sh/docs/accounts/local/signMessage#message

@LHerskind LHerskind added this to the Sequencer & Prover Testnet milestone Aug 22, 2024
@Maddiaa0
Copy link
Member Author

Viem offers no raw signing abilities

This is not true. See raw here: https://viem.sh/docs/accounts/local/signMessage#message

We were using this. But this still uses EIP191 format, i meant having an option to not do that

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants