Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitwise to precomputed lookup is using LookupIntoIndexedByClk instead of LookupIntoBitwise #12472

Closed
sirasistant opened this issue Mar 5, 2025 · 1 comment
Closed

Bitwise to precomputed lookup is using LookupIntoIndexedByClk instead of LookupIntoBitwise #12472

sirasistant opened this issue Mar 5, 2025 · 1 comment
Assignees
@jeanmon

Comments

@sirasistant
Copy link
Contributor

I believe std::make_unique<LookupIntoIndexedByClk<lookup_bitwise_byte_operations_settings>>(), should be std::make_unique<LookupIntoBitwise<lookup_bitwise_byte_operations_settings>>(),
No interaction tests were done since it wasn't possible at the time, tried adding one but it fails, maybe there is a bug in the precomputed table generation or something.
showcase here https://github.com/AztecProtocol/aztec-packages/pull/12471/files
@jeanmon
Copy link
Contributor

jeanmon commented Mar 6, 2025

Issue was solved as part of PR #12471

@jeanmon jeanmon closed this as completed Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanmon jeanmon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sirasistant @jeanmon