Don't doubly escape error messages. Fixes kratiahuja#34

Author: HodofHod

index.js

@@ -122,7 +122,7 @@ TSLint.prototype.processString = function(content, relativePath) {
 
 TSLint.prototype.testGenerator = function(relativePath, passed, errors) {
   if (errors) {
-    errors = '\\n' + this.escapeErrorString(errors);
+    errors = '\n' + errors;
   } else {
     errors = '';
   }
@@ -139,13 +139,6 @@ TSLint.prototype.testGenerator = function(relativePath, passed, errors) {
   }
 };
 
-TSLint.prototype.escapeErrorString = function(string) {
-  string = string.replace(/\n/gi, "\\n");
-  string = string.replace(/'/gi, "\\'");
-
-  return string;
-};
-
 TSLint.prototype.createLogMessage = function(message, color) {
   return chalk[color](message);
 }

tests/fixtures/errorFiles/errorFile2.ts

@@ -3,7 +3,7 @@ class A {
     {
         for(var i = 0; i < 10; ++i){
             debugger;
-            eval("something");
+            eval('something');
         }
     }
 }

tests/index.js

@@ -136,6 +136,22 @@ describe('broccoli-tslinter', function() {
     });
   });
 
+  it('generated test error messages should not be doubly escaped', function() {
+    var node = new TSLint('./tests/fixtures/errorFiles', {
+      logError: function(message) {
+        loggerOutput.push(message);
+      }
+    });
+    builder = new broccoli.Builder(node);
+    return builder.build().then(function() {
+      var dir = builder.outputPath;
+      var testGenerated = readFile(dir + '/errorFile2.lint-test.js');
+      assert.notInclude(testGenerated, "\\\\' should be", 'Single quotes are not doubly escaped');
+      assert.notInclude(testGenerated, "should be \\\"", 'Double quotes are not doubly escaped');
+      assert.notInclude(testGenerated, "\\\\n", 'Newlines are not doubly escaped');
+    });
+  });
+
   it('tests should not be generated when disableTestGenerator is true', function() {
     var node = new TSLint('./tests/fixtures/errorFiles', {
       logError: function(message) {