Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row Block: Custom width for Image Block isn't respected within the Row Block #98793

Closed
hacchism opened this issue Jan 23, 2025 · 5 comments
Closed
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Pri] Normal Schedule for the next available opportuinity. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@hacchism
Copy link

Context and steps to reproduce

If you add an Image Block and something else (i.e. Paragrah Block) into a Row Block, the image just gets smaller and smaller as you put more content into the other block even if you set custom width for the Image Block.

Steps to reproduce the issue:

  1. Activate one of the FSE themes. (i.e. Kentwood, TT5)
  2. Create a new page and add a Row Block.
  3. Add an Image Block and a Paragraph Block within the Row Block.
  4. Set a custom width for the Image Block.
  5. Check how the image appears on the live page depending on the volume of the content (text) you add into the Paragraph Block.

If you add lots of text into the Paragraph Block, the image eventually disappears.

Screen.Capture.on.2025-01-23.at.16-44-55.mp4

Site owner impact

Between 20% and 60% of the total website/platform users

Severity

Moderate

What other impact(s) does this issue have?

No revenue impact

If a workaround is available, please outline it here.

  • I've tested this with the Kentwood and TT5 theme only so far, but I guess this can be reproduced in other FSE themes.
  • I haven't tested it out on Atomic sites yet.
  • The workaround would be using the Columns Block.

Platform

Simple

@hacchism hacchism added [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Core Blocks Blocks that come with Gutenberg. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Jan 23, 2025
@github-actions github-actions bot added the [Pri] Normal Schedule for the next available opportuinity. label Jan 23, 2025
@supernovia
Copy link
Contributor

📌 REPRODUCTION RESULTS

  • Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO
I'm guessing that when we don't allow the rows to wrap, the system has to resize something and chooses to resize images rather than make very narrow paragraphs or create side-scrollbars. So I am guessing this is by design. Here are some screenshots that may help:

The settings / wide screen in the editor

Image

How it would look on mobile if we prioritized image widths

Image

How it looks now

Image

How it looks if we allow wrapping

Image

📌 ACTIONS

  • Requested author feedback

📌 Message to Author
@hacchism if the images didn't resize, the paragraph would likely become too narrow to read. Does using the "Allow to Wrap" toggle help?

@supernovia supernovia moved this from Needs Triage to In Triage in Automattic Prioritization: The One Board ™ Jan 23, 2025
@hacchism
Copy link
Author

hacchism commented Jan 23, 2025

Thanks @supernovia.

I'm guessing that when we don't allow the rows to wrap, the system has to resize something and chooses to resize images rather than make very narrow paragraphs or create side-scrollbars. So I am guessing this is by design.

This does make sense. Still, image disappearing in the end (depending on the content volume in the other block) feels off, though.

@hacchism if the images didn't resize, the paragraph would likely become too narrow to read. Does using the "Allow to Wrap" toggle help?

Yes, it does, but only in certain situations.

I'm also tagging @Greatdane here in case he has something to add. He got a related user report originally: 9321457-zen

Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 9321457-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Jan 23, 2025
@Greatdane
Copy link

Allow to wrap to multiple lines doesn't solve the original issue for the original reported user; 9321457-zd-a8c
(it just stacks no matter what)

For now, I changed to two columns as a work around.

@Robertght
Copy link

This has been discussed in more detail here: WordPress/gutenberg#68057

To quote another contributor:

It’s actually the size in the editor that is incorrect because it was decided that the Row block shouldn’t (by default) allow making unresponsive designs—discussion here: WordPress/gutenberg#45364 (comment).

I'm going to close this on our end as it should be addressed in core and it's already working as intended in the frontend.

@Robertght Robertght added [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Pri] Normal Schedule for the next available opportuinity. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Development

No branches or pull requests

4 participants