Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Editor: Inline Edit Button #8306

Closed
gwwar opened this issue Sep 28, 2016 · 6 comments
Closed

Image Editor: Inline Edit Button #8306

gwwar opened this issue Sep 28, 2016 · 6 comments
Assignees
@msmithgu
Labels
[Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] BLOCKER Requires immediate attention. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Milestone
Image Editor

Comments

@gwwar
Copy link
Contributor

gwwar commented Sep 28, 2016

Clicking on an image in the post editor brings up an in-context menu. Let's add an edit icon to that menu. When we click on that the inline edit button will bring up the details view of that image.

screen shot 2016-09-28 at 4 02 04 pm

Media Modal Details View:
screen shot 2016-09-28 at 3 54 13 pm
@gwwar gwwar added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Post/Page Editor The editor for editing posts and pages. [Feature] Media The media screen in Calypso, general media management, or integration with third party media. labels Sep 28, 2016
@gwwar gwwar added this to the Image Editor milestone Sep 28, 2016
@aduth
Copy link
Contributor

aduth commented Sep 29, 2016 •
edited
Loading

Related: #307, #2085, 10349-gh-calypso-pre-oss

Design-wise, there's been many discussions in the past about whether it should open the full details view or some custom view. If opening as the full details view, we should consider the effects of all possible actions (e.g. delete? return to library view [maybe replaces]?).

@aduth
Copy link
Contributor

aduth commented Sep 29, 2016

This kinda feels like a duplicate of #307

@gwwar
Copy link
Contributor Author

gwwar commented Sep 30, 2016

Thanks @aduth for the links! I can close this in favor of #307

@gwwar gwwar closed this as completed Sep 30, 2016
@rralian
Copy link
Contributor

rralian commented Feb 15, 2017

#307 is more broad and includes expanding the image modal to include other options. I would treat these separately and prioritize this one as the top priority for improving image-editing flow. It's most important that you can get to the existing image editor controls from an inline image.

@rralian rralian reopened this Feb 15, 2017
@rralian rralian added the [Pri] BLOCKER Requires immediate attention. label Feb 15, 2017
@rralian
Copy link
Contributor

rralian commented Feb 15, 2017

I'm setting the priority of this as a blocker for the image-editor v2 flow. IMHO it's the main point of the project and should be the first thing we do.

@msmithgu msmithgu self-assigned this Apr 26, 2017
@msmithgu msmithgu mentioned this issue Apr 27, 2017
Merged
@msmithgu msmithgu mentioned this issue May 5, 2017
Closed
@msmithgu msmithgu mentioned this issue May 16, 2017
Merged
@jblz
Copy link
Member

jblz commented May 22, 2017

Fixed via merging #14143

@jblz jblz closed this as completed May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msmithgu msmithgu

Labels
[Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] BLOCKER Requires immediate attention. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
Image Editor
Development

No branches or pull requests
5 participants
@rralian @msmithgu @gwwar @jblz @aduth