Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reader: rework Comment Store to use immutable #794

Closed
designsimply opened this issue Nov 25, 2015 · 1 comment
Closed

Reader: rework Comment Store to use immutable #794

designsimply opened this issue Nov 25, 2015 · 1 comment
Labels
[Feature] Reader The reader site on Calypso. [Pri] Low Address when resources are available. [Type] Task

Comments

@designsimply
Copy link
Contributor

Raised by @blowery

Right now we're mutating objects which will have issues if and when we start using PureRenderMixin. We're going to want to rework the Comment Store use immutable.
@designsimply designsimply added [Pri] Normal Schedule for the next available opportuinity. [Feature] Reader The reader site on Calypso. [Type] Task [Pri] Low Address when resources are available. and removed [Pri] Normal Schedule for the next available opportuinity. labels Nov 25, 2015
@blowery
Copy link
Contributor

blowery commented Dec 1, 2015

Closing this as we'll probably roll this into switching over to redux

@blowery blowery closed this as completed Dec 1, 2015
@gmovr gmovr mentioned this issue Jun 8, 2022
Merged
@awaisab172 awaisab172 mentioned this issue Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Reader The reader site on Calypso. [Pri] Low Address when resources are available. [Type] Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blowery @designsimply