Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: poll for changes in the comment list #792

Closed
designsimply opened this issue Nov 25, 2015 · 8 comments
Closed

Reader: poll for changes in the comment list #792

designsimply opened this issue Nov 25, 2015 · 8 comments
Labels
[Feature] Reader The reader site on Calypso. [Pri] Low Address when resources are available. [Status] Stale [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@designsimply
Copy link
Contributor

We should poll for changes in the comment list to show new comments.

Steps to reproduce:

  1. Go to https://wordpress.com/ and click on one of your blog posts to open it in a single-post view
  2. In a separate browser window, add and approve a new comment on the post
  3. Watch to see if the comment shows up

Result: new comments don't show up automatically when you are viewing a single post in the Reader and a new comment comes in.

@designsimply designsimply added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Pri] Normal Schedule for the next available opportuinity. [Feature] Reader The reader site on Calypso. [Pri] Low Address when resources are available. and removed [Pri] Normal Schedule for the next available opportuinity. labels Nov 25, 2015
@blowery blowery added this to the Reader: Feature Backlog milestone Dec 1, 2015
@alisterscott
Copy link
Contributor

Confirmed this behaviour has not changed - comments do not dynamically update in the Reader

@bluefuton
Copy link
Contributor

I started some of the plumbing for this in #26318 but it's not exposed on the UI yet. @westi suggested we use Pinghub rather than polling in the background.

@bluefuton
Copy link
Contributor

Just noting that @hewsut's #40396 adds real-time comments to Reader full post.

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@github-actions github-actions bot added the Stale label Feb 16, 2021
@bluefuton
Copy link
Contributor

This should have been fixed by #40396 but that will need to be confirmed (cc @worldomonation)

@worldomonation
Copy link
Contributor

I checked this behavior across multiple browsers and both Atomic and Simple.

I was not able to observe the real time comment fetching in a full page post.

Steps I took:

  1. log in as User A.
  2. open the post under test.
  3. as user A, in a separate tab open the Comments management section by going to My Sites > Site > Comments.
  4. as an unlogged in user, enter some comment on the post under test.
  5. as User A, refresh the tab used in Step 3.
  6. as User A, approve the comment.
  7. as User A, switch back to the the post under test.

The steps above were not able to demonstrate real-time comment loading when viewing a single post on both Atomic and Simple sites.

On Browser: Firefox Nightly 87.0a1 with Developer Tools > Network open, I was not able to observe any network requests being made.

Video demonstrating on an Atomic site:

Screen.Recording.2021-02-16.at.10.23.16.AM.mov

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@davemart-in
Copy link
Contributor

Gonna close this one for now. Happy to re-open if additional customers report it or if someone wants to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Reader The reader site on Calypso. [Pri] Low Address when resources are available. [Status] Stale [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

6 participants